Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add ESLint and Prettier Configuration #69

Open
2 tasks done
abhayymishraa opened this issue Nov 18, 2024 · 6 comments
Open
2 tasks done

Feat: Add ESLint and Prettier Configuration #69

abhayymishraa opened this issue Nov 18, 2024 · 6 comments

Comments

@abhayymishraa
Copy link
Contributor

Describe the feature

Currently our codebase lacks consistent code formatting and linting standards. This feature request is to add ESLint and Prettier configuration to maintain code quality and consistency.

Changes to be made:

  • Add ESLint for code linting
  • Add Prettier for consistent code formatting
  • Configure necessary dependencies and rules
  • Add scripts in package.json for linting and formatting

Expected Outcome:

  • Consistent code formatting across the project
  • Automated linting to catch potential issues
  • Better code quality and maintainability

Actually it should be added in the code so that the code formatting is good in the overall repository also eslint will catch the potential error . For first thing is apply the low level then the changes would be made in the eslintrc.json file according to the need

Add ScreenShots

image

Record

  • I agree to follow this project's Code of Conduct
  • I want to work on this issue
@abhayymishraa
Copy link
Contributor Author

I am working on the issue.

@abhayymishraa
Copy link
Contributor Author

@Pranav0-0Aggarwal Sir i have added linting the project the linting is not strict . also sir if we need to add strict in the linting in order to do that we should be make a lot of changes i am ready to take this job tooo but for now no strict just i introduced linting also i initialized the project with the prettier with tailwind config so that it will work with each other

@abhayymishraa
Copy link
Contributor Author

Also sir this many file changes is becuase of prettier format sir if u want i will remove the changes and will raise a pr with the functionality only also sir keep me updated about the eslint config thingy i will work on it and make it strict but sir also it require a lot of changes like use of "any " will give error so as you say i will do it sir

@abhayymishraa
Copy link
Contributor Author

abhayymishraa commented Nov 18, 2024

This is the command npm run format:fix
Screenshot from 2024-11-19 00-38-38
This is the command npm run format:check
Also this is how it look after formatting
Screenshot from 2024-11-19 00-37-51
more will be added

@Pranav0-0Aggarwal
Copy link
Member

is this issue resolved?

@abhayymishraa
Copy link
Contributor Author

yep we can add strict rule in linitng if we want but that needs a lot of change like in many component i saw that we used (any) which is not good for some scenarios we should declare types . @Pranav0-0Aggarwal if you will assign the next things i will work on it and define feature. where needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants