Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI doesn't fail at wrong clang-format, or compiler warnings #24

Open
2 tasks
forgottosave opened this issue Nov 14, 2024 · 0 comments
Open
2 tasks

CI doesn't fail at wrong clang-format, or compiler warnings #24

forgottosave opened this issue Nov 14, 2024 · 0 comments
Labels
🧱 CI CI run related (bug, new feature,...) 🐣 good first issue Good for newcomers state: 🛠️work There is work to do here

Comments

@forgottosave
Copy link
Collaborator

forgottosave commented Nov 14, 2024 •
edited
Loading

Description

Discovered in #21 (comment).

The clang-format check in the CI doesn't seem to fail, even if clang-format isn't applied.
Also: compiler warnings should be handled as an error!

Tasks

  • fix the CI run for the format check
  • add -Werror to clang-tidy
@forgottosave forgottosave added state: 🛠️work There is work to do here 🧱 CI CI run related (bug, new feature,...) labels Nov 14, 2024
@forgottosave forgottosave mentioned this issue Nov 14, 2024
Merged
15 tasks
@forgottosave forgottosave changed the title CI doesn't fail at wrong clang-format CI doesn't fail at wrong clang-format, or compiler warnings Dec 3, 2024
@forgottosave forgottosave added the 🐣 good first issue Good for newcomers label Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🧱 CI CI run related (bug, new feature,...) 🐣 good first issue Good for newcomers state: 🛠️work There is work to do here
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@forgottosave