You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When instantiating the class using the constructor:
TCPStream(const socket_stack_t stack);
there is no guarantee of a valid api being set. Thus if the connect method is then used, _socket.api
could be NULL. Should check this within the connect method.
If this is added then the method header should be updated accordingly.
Similarly for the setNagle() method. _socket.api could be invoked with a NULL value.
Also setNagle calls set_option() which returns an error type which is then ignored. Shouldn't this
error type be forwarded up to the caller of the method?
The text was updated successfully, but these errors were encountered:
When instantiating the class using the constructor:
TCPStream(const socket_stack_t stack);
there is no guarantee of a valid api being set. Thus if the connect method is then used, _socket.api
could be NULL. Should check this within the connect method.
If this is added then the method header should be updated accordingly.
Similarly for the setNagle() method. _socket.api could be invoked with a NULL value.
Also setNagle calls set_option() which returns an error type which is then ignored. Shouldn't this
error type be forwarded up to the caller of the method?
The text was updated successfully, but these errors were encountered: