Ambiguity in ACL Documentation

[fangyi-zhou]

In https://github.com/ARMmbed/uvisor/blob/master/docs/lib/API.md
acl_list is List of ACLs for the module

However, the the parameter is supposed to be ACLs for peripherals/IRQs

[fangyi-zhou]

acl_list is accessed here

uvisor/core/vmpu/src/vmpu.c

Line 330 in a7a649d

const UvisorBoxAclItem * region = box_cfgtbl->acl_list;

There is a check for whether the ACL is for IRQ, and assumes what is not IRQ is a peripheral. (Assumed from debug print)

uvisor/core/vmpu/src/vmpu.c

Line 351 in a7a649d

DPRINTF(" - Peripheral: 0x%08X - 0x%08X (permissions: 0x%04X)\r\n",

[fangyi-zhou]

Suggestion: Check whether UVISOR_TACL_PERIPHERAL is set and halt uVisor if check fails. Update the documentation accordingly.

[fangyi-zhou]

Also: in the case that the design intent of the acl_list covering a larger range of ACL list than only IRQ and peripherals, there are other things that need to be considered:

• Change the wording of debug message
• Inspect vmpu_is_buffer_access_ok and verify the assumptions on ACL vMPU region correspondence

[ciarmcom]

ARM Internal Ref: IOTSEC-415