-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option to include tropospheric correction data in INSAR_ISCE output #1416
Comments
@cmarshak @jhkennedy does this match your understanding of adding the tropospheric correction data to GUNW products generated with HyP3? I'm open to other ways to specify "don't include tropospheric correction", but this seems like the straightforward approach. |
This is great. |
Are Notably, |
This is a @dbekaert question. I believe we also want A nice to have would be some type of initial validation since the first step is so long running (generating a GUNW). |
@cmarshak We're close to releasing the first iteration of a new We picked 200 GUNW interferograms from ASF archive at random and attempted to regenerate them with each weather model, here are the results:
|
@jlmaurer @bbuzz31 thoughts on this? If there is temporal coverage issues, we should add a check as that's easy (no GIS).
Yes - this is a bit annoying(?) for hyp3 in terms of validation. But since Raider doesn't run until ISCE2 step is complete - this check would be very valuable to make sure we are not waiting around for hrrr to fail. But this (as it seems) would be a nice to have - unless its relatively easy for you all to implement.
@dbekaert wants to have this working - not sure if this is raider issue, permission issue, or hyp3 issue. Please clarify. |
@cmarshak Since HRES requires a special license agreement, we currently cannot access the dataset, since we do not have access to services/mars. I guess this is somewhat a hyp3 issue, since we don't have the proper permissions. |
@dbekaert is working on getting the license and I believe we won't be able to redistribute products for the first 24h after HRES data becomes available |
@cmarshak We've released the first iteration of including a new
If Final output netcdf products include layers created by running RAiDER's
|
This looks fantastic. Unbelievable work! Will this also work with INSAR_ISCE_TEST jobs? This would be ideal since we have a lot of testing and the production pipeline still triggers delivery to ASF. |
@cmarshak yes, this will work for both |
Out of curiousity - suppose for testing we are trying to submit 2 GUNWs but with different weather models within the same job - they will come out with the same ID presumably. Not sure about implications for ingestion, but flagging this here temporarily. |
@jacquelynsmale - can we also include On this note - is there a good way to cancel jobs (via hyp3-sdk) in case the jobs spin for 24+ hours due to data latency? More on this note - is there any idea of what kind of instances / costs per hour are related to the RAIDER step? |
@cmarshak, we can definitely add that as an option. @forrestfwilliams and I have started adding that as an option for |
@cmarshak we've not done a large-scale test but for the small number of jobs we've run (HRRR and GAMO), it looks like the RAiDER step increases the overall runtime by 2-4%. Since we're giving the same resources to DockerizedTopsApp and RAiDER, that directly translates to 2-4% increase in cost. We could do a more aggressive cost optimization for the RAiDER step, but with that little increase in cost it's not worth the developer time right now. |
I do think the raider step would benefit from some instance optimization in the not too distant future since raider requires significantly less compute and disk. Particularly since there are some risks with latency, this could help a lot with cost when we run things en masse. I think a coarse instance optimization would be an easier short-term, cost-saving measure than downloading a weather corpus and making that gel with the existing raider step function, though balancing these prospective paths is something we should discuss at the next hyp3 meeting. I would be happy to help with this in the coming months. |
https://github.com/dbekaert/RAiDER contains tools to calculate tropospheric corrections for radar. A
calcDelaysGUNW
utility was recently added to write additional tropospheric data layers into an existing GUNW netcdf product:raider.py ++process calcDelaysGUNW --model GMAO S1-GUNW-D-R-013-tops-20221223_20221129-142432-00127W_00038N-PP-8387-v2_0_6.nc
Possible values for the
--model
parameter are documented at https://github.com/dbekaert/RAiDER/blob/dev/docs/WeatherModels.mdThis feature request is to add a new
tropospheric_model
parameter to INSAR_ISCE jobs with possible values ofnone
(the default),HRRR
, andGMAO
:A job requested without specifying a model, or with a model of
none
, should produce the same output as currently provided. If a model is specified, the output netcdf product should be the output from runningcalcDelaysGUNW
using that model, including thetwo new tropospheric data layers:
The text was updated successfully, but these errors were encountered: