Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge INSAR_ISCE_MULTI_BURST into INSAR_ISCE_BURST #2448

Open
6 tasks
jtherrmann opened this issue Oct 2, 2024 · 0 comments
Open
6 tasks

Merge INSAR_ISCE_MULTI_BURST into INSAR_ISCE_BURST #2448

jtherrmann opened this issue Oct 2, 2024 · 0 comments
Labels
Jira Task Create a Jira Task for this issue

Comments

@jtherrmann
Copy link
Contributor

jtherrmann commented Oct 2, 2024

Jira: https://asfdaac.atlassian.net/browse/TOOL-3166

Note: The above link is accessible only to members of ASF.


Currently we have an INSAR_ISCE_MULTI_BURST job spec (which takes reference and secondary parameters) and a separate INSAR_ISCE_BURST job spec (which takes a granules parameter) because it was the easiest way to merge the multi-burst work to main without breaking backwards compatibility for INSAR_ISCE_BURST.

When we're ready to break backwards compatibility by replacing the granules parameter, we'll need to:

  • Rename INSAR_ISCE_MULTI_BURST.yml to INSAR_ISCE_BURST.yml (replacing the existing INSAR_ISCE_BURST.yml)
  • Rename the job type to INSAR_ISCE_BURST (first line of the job spec)
  • Remove INSAR_ISCE_MULTI_BURST.yml from hyp3-multi-burst-sandbox deployment
  • Currently the validate_jobs function calls convert_single_burst_jobs to convert the parameters for all INSAR_ISCE_BURST jobs from granules to reference and secondary in validation.py. This can be removed, along with any test cases for the granules parameter for insar burst jobs.
  • Rename INSAR_ISCE_MULTI_BURST to INSAR_ISCE_BURST everywhere it's used in the code (see git grep INSAR_ISCE_MULTI_BURST); should just be set_batch_overrides.py, test_set_batch_overrides.py, and test_validation.py
  • Update the parameters in all old INSAR_ISCE_BURST job records, so that interacting with existing jobs does not break; this will need to be done for test deployments as we merge to develop, and then for prod deployments as we merge to main
@jtherrmann jtherrmann added the Jira Task Create a Jira Task for this issue label Oct 2, 2024
@jtherrmann jtherrmann changed the title Remove the deprecated granules parameter from INSAR_ISCE_BURST Merge INSAR_ISCE_MULTI_BURST into INSAR_ISCE_BURST Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Jira Task Create a Jira Task for this issue
Projects
None yet
Development

No branches or pull requests

1 participant