Page not scrolling to the new command prompt if goes beyond the original page.

[chlee0925]

Hi! Thanks so much for the repo. I am really enjoying playing with the library.
I found that when I reached the bottom of the page, it was not automatically scrolling to the new command prompt.

How to reproduce:
Keep executing commands till you reach the bottom of the page.

I fixed it by inserting
window.scrollTo(0, document.body.scrollHeight); at the end of resetPrompt function.

If you can reproduce the bug and are happy about my fix, I would love to send you a pull request.
Thanks for reading.

[AVGP]

Hey there, sorry it took me so long to respond! Thanks for catching this issue and providing a solution, I'd love to see a pull request for it! Let me know if I can help with something! Cheers, Martin On 6 Jul 2017 8:04 am, "chlee0925" <[email protected]> wrote: Hi! Thanks so much for the repo. I am really enjoying playing with the library. I found that when I reached the bottom of the page, it was not automatically scrolling to the new command prompt. How to reproduce: Keep executing commands till you reach the bottom of the page. I fixed it by inserting window.scrollTo(0, document.body.scrollHeight); at the end of resetPrompt function. If you can reproduce the bug and are happy about my fix, I would love to send you a pull request. Thanks for reading. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#7>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAWmRk5yoyotYcRtAONHSdQMiNz-9FR9ks5sLHjUgaJpZM4OPMe9> .

[chlee0925]

Thank you so much for your reply!
I have tried Chrome (60.0.3112.90), Firefox (53.0.3), and Safari (10.1.1) and found that only Safari had this issue. The fix will resolve for all three browsers.

Cheers,
Juho