Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix handling of unit values -- repackAcc broken for Array of Z #11

Open
rrnewton opened this issue Feb 23, 2014 · 1 comment
Open

Fix handling of unit values -- repackAcc broken for Array of Z #11

rrnewton opened this issue Feb 23, 2014 · 1 comment
Milestone
1.0

Comments

@rrnewton
Copy link
Member

In particular for types like Acc (Array (Z:.Int) Z).

It gets this:

run test 20/67 p13g2:: [Failed]
ERROR: concatAccArrays: Cannot zip an empty list of AccArrays (don't know dimension)

I added a unit test to backend-kit/tests/UnitTests.hs that reproduces this.
rrnewton added a commit that referenced this issue Feb 23, 2014
@rrnewton
Fix issue #11. At least in a narrow sense.
93ec220 
This is only part of the story, however.  We've still managed to introduce all the
following test failures with the new policy on treating unit arrays:

----------------------------------------

run test 12/67 p11:: [Failed]
ERROR: repackAcc2: ran out of input arrays.

run test 13/67 p11b:: [Failed]
ERROR: repackAcc2: ran out of input arrays.

run test 14/67 p11c:: [Failed]
ERROR: repackAcc2: ran out of input arrays.

----------------------------------------

run test 23/67 p13j:: [Failed]
ERROR: packArray: given a AccArray of the wrong type, expected Int received 2 payloads:
ArrayPayloadUnit 1
ArrayPayloadInt (array (0,0) [(0,-5764607523034234880)])

 dimension: []

----------------------------------------

run test 64/67 p5:: [Failed]
ERROR: packArray: given a AccArray of the wrong type, expected Int received 3 payloads:
ArrayPayloadUnit 1
ArrayPayloadInt (array (0,0) [(0,-6917529027641081856)])
ArrayPayloadUnit 1

----------------------------------------
@rrnewton
Copy link
Member Author

p5 is a good example. The simpleResult in the TestEntry is WRONG (as of master depth 532).

@rrnewton rrnewton added this to the 1.0 milestone Feb 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
1 participant
@rrnewton