Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Landmarks with aria-labelledby tested positive but actually does not work #287

Closed
hrvojegolcic opened this issue Jul 9, 2020 · 4 comments · Fixed by #402
Closed

Landmarks with aria-labelledby tested positive but actually does not work #287

hrvojegolcic opened this issue Jul 9, 2020 · 4 comments · Fixed by #402

Comments

@hrvojegolcic
Copy link

hrvojegolcic commented Jul 9, 2020

Current state

The page examples/headings/alternative-techniques under the heading "Description using ARIA (optional)" contains a codepan example and a positive test case as such:

image

Issue

I've re-tested locally and noticed the following 2 issues while testing this example:

  1. NVDA: Landmark label ignored if aria-labelledby refers a child element. It means that a distinguishable landmark label is not announced at all aside to a landmark role when navigating by a TAB key. See:
    image

  2. IE 11 is very funny about it. When navigating by TAB key apparently if aria-labelledby is used on a landmark (e.g. nav, region) NVDA+IE 11 will read the entire inner content as a landmark label unless it refers to an "IE accessible element" (Must have a role or tabindex). See my testing with TAB key:
    image

Therefore it seems like the example and the test case are no longer valid for NVDA.

My setup

  • Windows 8.1
  • NVDA 2020.1
  • Chrome 80.0.3987.122
  • Edge 83.0.478.61
  • Firefox 77.0.1
  • IE 11.0.9600.19724 (version update 11.0.195)
@jmuheim
Copy link
Collaborator

jmuheim commented Oct 22, 2020

Dear @hrvojegolcic

Thanks for your thorough investigation and explanation. First of all, we don't support IE11 in general anymore (we adapted to current user statistics, see https://www.accessibility-developer-guide.com/knowledge/screen-readers/relevant-combinations/#what-about-ie). Also, we never supported IE11+NVDA.

So is this still a problem? I'm not certain what combination of NVDA+browser you used for the first example, and whether what you're describing is a problem? 😃

@hrvojegolcic
Copy link
Author

hrvojegolcic commented Oct 24, 2020

Hi @jmuheim, thank you for your response.

In that case the second issue can be ignored but the first issue unfortunately still remains, as reported directly to NVDA repo.

I've tested with (then) newest NVDA and newest Firefox versions and it does NOT PASS.
Exact setup and versions are mentioned in the post.
I did not test with old NVDA and old Firefox Quantum 59 and either way this would be outdated now. The issue does exists.

@backflip
Copy link
Collaborator

@ManuA4A, could Franco have a look at this, too?

@backflip
Copy link
Collaborator

backflip commented May 8, 2023

Successfully tested with latest NVDA (2023.1) on latest Firefox (112) on Windows 11. I will update the test result matrix accordingly.

@backflip backflip self-assigned this May 8, 2023
@backflip backflip moved this to Todo in ADG May 12, 2023
@backflip backflip added this to ADG May 12, 2023
@backflip backflip moved this from Todo to In Progress in ADG May 12, 2023
@NicSR NicSR moved this from In Progress to Testing ZFA in ADG May 17, 2023
backflip added a commit that referenced this issue May 22, 2023
…techniques-nvda

feat: update compatibility matrix for headings demo, resolves #287
@github-project-automation github-project-automation bot moved this from Testing ZFA to Done in ADG May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants