Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rails engine? #8

Open
jamesvanmil opened this issue Jun 8, 2015 · 7 comments
Open

Rails engine? #8

jamesvanmil opened this issue Jun 8, 2015 · 7 comments
Assignees

Comments

@jamesvanmil
Copy link
Contributor

Following the lead of Questioning Authority, I think this should be a Rails engine. Any good reason not to do this?

@tpendragon
Copy link

With the idea being that you can mount the app in other apps? I'm not particularly against it, just no experience in writing them. Can you spin it up as an engine?

@jamesvanmil
Copy link
Contributor Author

Yeah that's my thought. I think I can modify the existing code base to enginfy it without interfering with other work.

@no-reply
Copy link
Member

I'm working on a refactor that makes these fragments mountable. This may take the form of a larger refactor that moves the core code out into a Rack module. Updates to come.

@no-reply
Copy link
Member

no-reply commented Feb 5, 2017

@hackartisan
Copy link

@no-reply is this issue closed? LDCX notes reference 'axing rails engine' which would imply yes.

However, notes from LDCX indicate that there is a bit of final alignment to do; can you give more details on whether that is a matter of PRing existing work or creating a new ticket to... discuss? take some (what?) action?

"Other topic with respect to LDF gem, Tom took logic out of rails part of that gem and in DCE branch, there are 2 equivalent server applications. Share all logic except routing. Would advocate possibly axing rails engine, no reason you can’t mount any rails app you like to rack. Want buy-in for rack instead of rails (rails is heavyweight for this work context)" (from https://docs.google.com/document/d/1yr7dIlKzWmaVLf-2easbaQvY5UF8tf0_ylr8RIKWprY/edit)

@jcoyne
Copy link
Contributor

jcoyne commented May 12, 2017

Hmm, I was unable to be at the LDCX discussion, but I'm still leaning towards possibly making this an engine as it would make the deployment story much easier.

@jcoyne
Copy link
Contributor

jcoyne commented May 12, 2017

I would like to hear more about the non-rails server applications that @no-reply has devised.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants