Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add field to customize font #510

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Rickard-Martensson
Copy link

Currently the only way to modify the default font is to build it yourself. I feel like its a basic enough feature to give it its own field in the settings

@ErikBjare
Copy link
Member

ErikBjare commented Nov 22, 2023

Sorry, but I do not think this is important enough to make it a whole section in the settings. Almost no one will change this setting, so I don't want to maintain it.

If you want to change the font, you can use a browser extension/user style to override. You don't need to rebuild the thing to change it that way.

But since I appreciate the effort, I can still merge the part where you refactored the style.scss, so you get some contributor cred, and can easily override it yourself with user styles :)

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f38648c) 23.76% compared to head (a95a147) 23.76%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #510   +/-   ##
=======================================
  Coverage   23.76%   23.76%           
=======================================
  Files          27       27           
  Lines        1616     1616           
  Branches      269      269           
=======================================
  Hits          384      384           
  Misses       1206     1206           
  Partials       26       26           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


$default-font-family: -apple-system, BlinkMacSystemFont, "Segoe UI", "Roboto", "Helvetica Neue", "Ubuntu", sans-serif;
$header-font-family: 'Varela Round', sans-serif;
$canvas-font-family: sans-serif;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what's different for canvas vs default?
Perhaps they should be combined?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants