-
-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(timeline): swimlanes, duration filter, and filter desc to timeline #530
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #530 +/- ##
==========================================
- Coverage 25.55% 25.32% -0.24%
==========================================
Files 27 28 +1
Lines 1616 1631 +15
Branches 273 279 +6
==========================================
Hits 413 413
- Misses 1177 1186 +9
- Partials 26 32 +6 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very neat!
Just a couple comments that would improve the typing a bit.
Feel free to simply apply them from the GitHub UI if they look good to you, and you don't expect them to break things :)
Haven't tested it myself locally, will do that right before I merge.
Co-authored-by: Erik Bjäreholt <[email protected]>
@ErikBjare, thanks for the suggestions. I've added them and rebuilt. It all looks good. |
…te range and no events. Previous implementation wouldn't update with changed time if no events found.
This allows filter and swimlane options to be changed without losing your location.
@ErikBjare, I added some additional adjustments so that the refreshes to the timeline are more predictable you don't lose your location when changing filters. There may be a better way to pass the updateTimelineWindow than using a separate boolean. If there is a better way of doing it than I did I can rework it if you provide some direction. This is the last I'm doing on this PR. I hope to add another time format PR, but not sure when I'll be working on this. |
Background
I've used AW for some time and found it very useful. However, the timeline view can be hard to understand when switching windows and tabs quickly throughout the day. For example:
I wanted the ability to separate the timeline into swim lanes based on various event attributes.
New Features
Feature 1: I've added 2 different swimlane options to this PR:
currentwindow
, domain name forweb.tab.current
)Feature 2: I added a filter summary description when the filter is closed.
Feature 3: To reduce the number of swimlanes and confusion in the timeline I also added a filter to only include events that are a minimum duration as well.
Implementation Notes
subgroup
on the vizjs timeline inTimeline.vue
.util/swimlane.js
file is added to calculate the swimlane/subgroup value.viz-timeline
component for filtering the events.Further Improvement Ideas
Some ideas on where this could still go for improvement:
util/tooltip.js
).@ErikBjare, this is my first PR for the project. If I've missed something obvious, please let me know and I'll try to submit a fix. Thanks for all your time and the other contributors.