Rock YuliyaP final version viewing party #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yukka-pukka
changed the title
spitsfire
reviewed
Apr 4, 2021
| @@ -0,0 +1,131 @@ | |||
| # WAVE One | |||
| def create_movie(movie_title, genre, rating): | |||
Comment on lines
+3
to
+12
| movie = {} | ||
| movie['title'] = movie_title | ||
| movie['genre'] = genre | ||
| movie['rating'] = rating | ||
|
|
||
| for values in movie.values(): | ||
| if values == None: | ||
| return None | ||
|
|
||
| return movie |
There was a problem hiding this comment.
this works just fine! but we are creating space in memory with a variable movie that might no even be valid yet! so let's think about checking validation before making variables and running code that MIGHT not be needed
Suggested change
| movie = {} | |
| movie['title'] = movie_title | |
| movie['genre'] = genre | |
| movie['rating'] = rating | |
| for values in movie.values(): | |
| if values == None: | |
| return None | |
| return movie | |
| if movie_title and genre and rating: # does these values "exist"/are they truthy? | |
| movie = {"title": movie_title, "genre": genre, "rating": rating} | |
| return movie | |
| else: | |
| return None |
| return movie | ||
|
|
||
|
|
||
| def add_to_watched(user_data, movie): |
| return user_data | ||
|
|
||
|
|
||
| def add_to_watchlist(user_data, movie): |
| return user_data | ||
|
|
||
|
|
||
| def watch_movie(user_data, title): |
| return (unique_watched) | ||
|
|
||
|
|
||
| def get_friends_unique_watched(user_data): |
| # Wave Four | ||
|
|
||
|
|
||
| def get_available_recs(user_data): |
|
|
||
|
|
||
| def get_available_recs(user_data): | ||
| friends_unique_movies = get_friends_unique_watched(user_data) |
There was a problem hiding this comment.
great job reusing a function you've already defined
|
|
||
| # Wave Five (version3) | ||
|
|
||
| def get_new_rec_by_genre(user_data): |
|
|
||
| return recommended_movies | ||
|
|
||
| def get_rec_from_favorites(user_data): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.