diff --git a/app/__init__.py b/app/__init__.py index 2764c4cc8..165f604d6 100644 --- a/app/__init__.py +++ b/app/__init__.py @@ -1,8 +1,8 @@ from flask import Flask from flask_sqlalchemy import SQLAlchemy from flask_migrate import Migrate -import os from dotenv import load_dotenv +import os db = SQLAlchemy() @@ -29,6 +29,11 @@ def create_app(test_config=None): db.init_app(app) migrate.init_app(app, db) - # Register Blueprints here + # Register Blueprints + from .routes import task_list_bp + app.register_blueprint(task_list_bp) + + from .goal_routes import goal_bp + app.register_blueprint(goal_bp) return app diff --git a/app/goal_routes.py b/app/goal_routes.py new file mode 100644 index 000000000..ce81bee67 --- /dev/null +++ b/app/goal_routes.py @@ -0,0 +1,124 @@ +from app import db +from app.models.task import Task +from app.models.goal import Goal +from flask import Blueprint, jsonify, make_response, request, abort +from sqlalchemy.types import DateTime +from sqlalchemy.sql.functions import now +import requests, json +import os + +goal_bp = Blueprint("goal_bp", __name__, url_prefix="/goals") + +def validate_model_goal(cls, model_id): + try: + model_id = int(model_id) + except: + abort(make_response({"message": f"{cls.__name__} {model_id} invalid"}, 400)) + + goal = cls.query.get(model_id) + + if not goal: + abort(make_response({"message": f"{cls.__name__} {model_id} not found"}, 404)) + + return goal + +@goal_bp.route("", methods=["POST"]) +def create_goal(): + request_body = request.get_json() + is_valid_goal = "title" in request_body + if not is_valid_goal: + abort(make_response({"details": "Invalid data"}, 400)) + + new_goal = Goal.goal_from_dict(request_body) + + db.session.add(new_goal) + db.session.commit() + + response_body = { + "goal": new_goal.goal_to_dict() + } + + return make_response(jsonify(response_body), 201) + +@goal_bp.route("", methods=["GET"]) +def get_all_goals(): + # goal = validate_model_goal() + sort_query = request.args.get("sort") + if sort_query == "asc": + goals = Goal.query.order_by(Goal.title) + elif sort_query == "desc": + goals = Goal.query.order_by(Goal.title.desc()) + else: + goals = Goal.query.all() + + goals_response = [goal.goal_to_dict() for goal in goals] + return jsonify(goals_response) + +@goal_bp.route("/", methods=["GET"]) +def get_one_goal(goal_id): + goal = validate_model_goal(Goal, goal_id) + response_body = { + "goal": goal.goal_to_dict() + } + return jsonify(response_body) + +@goal_bp.route("/", methods=["PUT"]) +def update_goal(goal_id): + goal = validate_model_goal(Goal, goal_id) + request_body = request.get_json() + goal.title = request_body["title"] + + db.session.commit() + + response_body = { + "goal": goal.goal_to_dict() + } + return response_body + +@goal_bp.route("/", methods=["DELETE"]) +def delete_goal(goal_id): + goal = validate_model_goal(Goal, goal_id) + response_body = { + "details": f'Goal {goal.goal_id} \"{goal.title}\" successfully deleted' + } + + db.session.delete(goal) + db.session.commit() + + return response_body + +@goal_bp.route("//tasks", methods=["POST"]) +def create_task(goal_id): + # validate goal_id + goal = validate_model_goal(Goal, goal_id) + + request_body = request.get_json() + + db.session.add(request_body) + db.session.commit() + + tasks_resp = [tasks_resp for task in ask.task_with_goal_to_dict] + goal.goal_to_dict_with_task() // t + + return jsonify(response_body) + +@goal_bp.route("//tasks", methods=["GET"]) +def get_tasks_one_goal(goal_id): + + goal = validate_model_goal(Goal, goal_id) + + tasks_response = [] + for task in goal.tasks: + tasks_response.append( + { + "id": task.task_id, + "title": task.title, + "description": task.description, + "completed_at": None + "goal_id": + } + ) + # + # tasks_response = [response_dict for task in goal.tasks] + + return jsonify(tasks_response) diff --git a/app/models/goal.py b/app/models/goal.py index b0ed11dd8..cc59ddfdd 100644 --- a/app/models/goal.py +++ b/app/models/goal.py @@ -2,4 +2,33 @@ class Goal(db.Model): - goal_id = db.Column(db.Integer, primary_key=True) + goal_id = db.Column(db.Integer, primary_key=True, autoincrement=True) + title = db.Column(db.String) + tasks = db.relationship("Task", back_populates="goal", lazy=True) + + @classmethod + def goal_from_dict(cls, goal_data): + new_goal = Goal(title=goal_data["title"]) + return new_goal + + def goal_to_dict(self): + goal_as_dict = {} + + goal_as_dict["id"] = self.goal_id + goal_as_dict["title"] = self.title + if self.tasks: + task_list = [] + for task in self.tasks: + task_list.append(task.task_to_dict(self)) + goal_as_dict["tasks"] = task_list + + return goal_as_dict + + def goal_to_dict_with_task(self): + goal_as_dict = {} + + goal_as_dict["id"] = self.goal_id + goal_as_dict["title"] = self.title + goal_as_dict["tasks"] = self.tasks + + return goal_as_dict \ No newline at end of file diff --git a/app/models/task.py b/app/models/task.py index c91ab281f..9e5ea9c8a 100644 --- a/app/models/task.py +++ b/app/models/task.py @@ -1,5 +1,46 @@ from app import db +from app.models.goal import Goal class Task(db.Model): - task_id = db.Column(db.Integer, primary_key=True) + """Task definition""" + task_id = db.Column(db.Integer, primary_key=True, autoincrement=True) + title = db.Column(db.String) + description = db.Column(db.String) + completed_at = db.Column(db.DateTime, nullable=True) + goal_id = db.Column(db.Integer, db.ForeignKey("goal.goal_id")) + goal = db.relationship("Goal", back_populates="tasks") + + @classmethod + def task_from_dict(cls, task_data): + """Input task as a dictionary. Assumes None/null for completed_at""" + + if not "completed_at" in task_data: + task_data["completed_at"] = None + + new_task = Task(title=task_data["title"], + description=task_data["description"], + completed_at=task_data["completed_at"]) + return new_task + + def task_to_dict(self): + """Output task information as a dictionary""" + task_as_dict = {} + + task_as_dict["id"] = self.task_id + task_as_dict["title"] = self.title + task_as_dict["description"] = self.description + task_as_dict["is_complete"] = self.completed_at != None + + return task_as_dict + + def task_with_goal_to_dict(self): + task_as_dict = {} + + task_as_dict["id"] = self.task_id + task_as_dict["title"] = self.title + task_as_dict["description"] = self.description + task_as_dict["is_complete"] = self.completed_at != None + task_as_dict["goal_id"] = self.goal_id + + return task_as_dict diff --git a/app/routes.py b/app/routes.py index 3aae38d49..14ed926ae 100644 --- a/app/routes.py +++ b/app/routes.py @@ -1 +1,161 @@ -from flask import Blueprint \ No newline at end of file +from app import db +from app.models.task import Task +from app.models.goal import Goal +from flask import Blueprint, jsonify, make_response, request, abort +from sqlalchemy.types import DateTime +from sqlalchemy.sql.functions import now +import requests, json +import os +# import logging +# from slack_sdk import WebClient +# from slack_sdk.errors import SlackApiError + + +task_list_bp = Blueprint("task_list_bp", __name__, url_prefix="/tasks") + +def validate_model_task(cls, model_id): + try: + model_id = int(model_id) + except: + abort(make_response({"message": f"{cls.__name__} {model_id} invalid"}, 400)) + + task = cls.query.get(model_id) + + if not task: + abort(make_response({"message": f"{cls.__name__} {model_id} not found"}, 404)) + + return task + +@task_list_bp.route("", methods=["POST"]) +def create_task(): + request_body = request.get_json() + is_valid_task = "title" in request_body and "description" in request_body + if not is_valid_task: + abort(make_response({"details": "Invalid data"}, 400)) + + new_task = Task.task_from_dict(request_body) + + db.session.add(new_task) + db.session.commit() + + response_body = { + "task": new_task.task_to_dict() + } + return make_response(jsonify(response_body), 201) + + +@task_list_bp.route("", methods=["GET"]) +def get_all_tasks(): + sort_query = request.args.get("sort") + if sort_query == "asc": + tasks = Task.query.order_by(Task.title) + elif sort_query == "desc": + tasks = Task.query.order_by(Task.title.desc()) + else: + tasks = Task.query.all() + + tasks_response = [task.task_to_dict() for task in tasks] + return jsonify(tasks_response) + +@task_list_bp.route("/", methods=["GET"]) +def get_one_task(task_id): + task = validate_model_task(Task, task_id) + response_body = { + "task": task.task_to_dict() + } + return jsonify(response_body) + +@task_list_bp.route("/", methods=["PUT"]) +def update_task(task_id): + task = validate_model_task(Task, task_id) + request_body = request.get_json() + task.title = request_body["title"] + task.description = request_body["description"] + + db.session.commit() + + response_body = { + "task": task.task_to_dict() + } + return response_body + +@task_list_bp.route("/", methods=["DELETE"]) +def delete_task(task_id): + task = validate_model_task(Task, task_id) + response_body = { + "details": f'Task {task.task_id} \"{task.title}\" successfully deleted' + } + + db.session.delete(task) + db.session.commit() + + return response_body + +@task_list_bp.route("//mark_complete", methods=["PATCH"]) +def mark_task_complete(task_id): + request_body = request.get_json() + + try: + task = Task.query.get(task_id) + task.completed_at = now() + except: + return abort(make_response({"message": f"{task_id} not found"}, 404)) + + db.session.commit() + + response_body = { + "task": task.task_to_dict() + } + + SLACK_BOT_TOKEN = os.environ.get("SLACK_BOT_TOKEN") + my_headers = { + "Authorization": f"Bearer {SLACK_BOT_TOKEN}" + } + + data_payload = { + "channel": "task-notifications", + "text": f"Someone just completed the task {task.title}" + } + + requests.post("https://slack.com/api/chat.postMessage", + headers=my_headers, + data=data_payload) + + return jsonify(response_body) + + + # ~~Below is the the code I would have used given Slack documentation for calling their API~~ + + # client = WebClient(token=os.environ.get("SLACK_BOT_TOKEN")) + # logger = logging.getLogger(__name__) + # channel_id = "task-notifications" + + # try: + # # Call the chat.postMessage method using the WebClient + # result = client.chat_postMessage( + # channel=channel_id, + # text=f"Someone just completed the task {task.title}." + # ) + # logger.info(result) + + # except SlackApiError as e: + # logger.error(f"Error posting message: {e}") + + + +@task_list_bp.route("//mark_incomplete", methods=["PATCH"]) +def mark_task_incomplete(task_id): + request_body = request.get_json() + try: + task=Task.query.get(task_id) + task.completed_at = None + except: + response_body = abort(make_response({"message": f"{task_id} not found"}, 404)) + return response_body + + db.session.commit() + response_body = { + "task": task.task_to_dict() + } + + return jsonify(response_body) diff --git a/migrations/README b/migrations/README new file mode 100644 index 000000000..98e4f9c44 --- /dev/null +++ b/migrations/README @@ -0,0 +1 @@ +Generic single-database configuration. \ No newline at end of file diff --git a/migrations/alembic.ini b/migrations/alembic.ini new file mode 100644 index 000000000..f8ed4801f --- /dev/null +++ b/migrations/alembic.ini @@ -0,0 +1,45 @@ +# A generic, single database configuration. + +[alembic] +# template used to generate migration files +# file_template = %%(rev)s_%%(slug)s + +# set to 'true' to run the environment during +# the 'revision' command, regardless of autogenerate +# revision_environment = false + + +# Logging configuration +[loggers] +keys = root,sqlalchemy,alembic + +[handlers] +keys = console + +[formatters] +keys = generic + +[logger_root] +level = WARN +handlers = console +qualname = + +[logger_sqlalchemy] +level = WARN +handlers = +qualname = sqlalchemy.engine + +[logger_alembic] +level = INFO +handlers = +qualname = alembic + +[handler_console] +class = StreamHandler +args = (sys.stderr,) +level = NOTSET +formatter = generic + +[formatter_generic] +format = %(levelname)-5.5s [%(name)s] %(message)s +datefmt = %H:%M:%S diff --git a/migrations/env.py b/migrations/env.py new file mode 100644 index 000000000..8b3fb3353 --- /dev/null +++ b/migrations/env.py @@ -0,0 +1,96 @@ +from __future__ import with_statement + +import logging +from logging.config import fileConfig + +from sqlalchemy import engine_from_config +from sqlalchemy import pool +from flask import current_app + +from alembic import context + +# this is the Alembic Config object, which provides +# access to the values within the .ini file in use. +config = context.config + +# Interpret the config file for Python logging. +# This line sets up loggers basically. +fileConfig(config.config_file_name) +logger = logging.getLogger('alembic.env') + +# add your model's MetaData object here +# for 'autogenerate' support +# from myapp import mymodel +# target_metadata = mymodel.Base.metadata +config.set_main_option( + 'sqlalchemy.url', + str(current_app.extensions['migrate'].db.engine.url).replace('%', '%%')) +target_metadata = current_app.extensions['migrate'].db.metadata + +# other values from the config, defined by the needs of env.py, +# can be acquired: +# my_important_option = config.get_main_option("my_important_option") +# ... etc. + + +def run_migrations_offline(): + """Run migrations in 'offline' mode. + + This configures the context with just a URL + and not an Engine, though an Engine is acceptable + here as well. By skipping the Engine creation + we don't even need a DBAPI to be available. + + Calls to context.execute() here emit the given string to the + script output. + + """ + url = config.get_main_option("sqlalchemy.url") + context.configure( + url=url, target_metadata=target_metadata, literal_binds=True + ) + + with context.begin_transaction(): + context.run_migrations() + + +def run_migrations_online(): + """Run migrations in 'online' mode. + + In this scenario we need to create an Engine + and associate a connection with the context. + + """ + + # this callback is used to prevent an auto-migration from being generated + # when there are no changes to the schema + # reference: http://alembic.zzzcomputing.com/en/latest/cookbook.html + def process_revision_directives(context, revision, directives): + if getattr(config.cmd_opts, 'autogenerate', False): + script = directives[0] + if script.upgrade_ops.is_empty(): + directives[:] = [] + logger.info('No changes in schema detected.') + + connectable = engine_from_config( + config.get_section(config.config_ini_section), + prefix='sqlalchemy.', + poolclass=pool.NullPool, + ) + + with connectable.connect() as connection: + context.configure( + connection=connection, + target_metadata=target_metadata, + process_revision_directives=process_revision_directives, + **current_app.extensions['migrate'].configure_args + ) + + with context.begin_transaction(): + context.run_migrations() + + +if context.is_offline_mode(): + run_migrations_offline() +else: + run_migrations_online() diff --git a/migrations/script.py.mako b/migrations/script.py.mako new file mode 100644 index 000000000..2c0156303 --- /dev/null +++ b/migrations/script.py.mako @@ -0,0 +1,24 @@ +"""${message} + +Revision ID: ${up_revision} +Revises: ${down_revision | comma,n} +Create Date: ${create_date} + +""" +from alembic import op +import sqlalchemy as sa +${imports if imports else ""} + +# revision identifiers, used by Alembic. +revision = ${repr(up_revision)} +down_revision = ${repr(down_revision)} +branch_labels = ${repr(branch_labels)} +depends_on = ${repr(depends_on)} + + +def upgrade(): + ${upgrades if upgrades else "pass"} + + +def downgrade(): + ${downgrades if downgrades else "pass"} diff --git a/migrations/versions/1dabb5ea2f8a_.py b/migrations/versions/1dabb5ea2f8a_.py new file mode 100644 index 000000000..7f1de734b --- /dev/null +++ b/migrations/versions/1dabb5ea2f8a_.py @@ -0,0 +1,40 @@ +"""empty message + +Revision ID: 1dabb5ea2f8a +Revises: +Create Date: 2023-05-09 15:17:27.392799 + +""" +from alembic import op +import sqlalchemy as sa + + +# revision identifiers, used by Alembic. +revision = '1dabb5ea2f8a' +down_revision = None +branch_labels = None +depends_on = None + + +def upgrade(): + # ### commands auto generated by Alembic - please adjust! ### + op.create_table('goal', + sa.Column('goal_id', sa.Integer(), nullable=False), + sa.PrimaryKeyConstraint('goal_id') + ) + op.create_table('task', + sa.Column('task_id', sa.Integer(), autoincrement=True, nullable=False), + sa.Column('title', sa.String(), nullable=True), + sa.Column('description', sa.String(), nullable=True), + sa.Column('completed_at', sa.DateTime(), nullable=True), + sa.Column('is_complete', sa.String(), nullable=True), + sa.PrimaryKeyConstraint('task_id') + ) + # ### end Alembic commands ### + + +def downgrade(): + # ### commands auto generated by Alembic - please adjust! ### + op.drop_table('task') + op.drop_table('goal') + # ### end Alembic commands ### diff --git a/migrations/versions/28405e468053_.py b/migrations/versions/28405e468053_.py new file mode 100644 index 000000000..dc34ff849 --- /dev/null +++ b/migrations/versions/28405e468053_.py @@ -0,0 +1,28 @@ +"""empty message + +Revision ID: 28405e468053 +Revises: 895aa5ab74ee +Create Date: 2023-05-10 15:24:55.316424 + +""" +from alembic import op +import sqlalchemy as sa + + +# revision identifiers, used by Alembic. +revision = '28405e468053' +down_revision = '895aa5ab74ee' +branch_labels = None +depends_on = None + + +def upgrade(): + # ### commands auto generated by Alembic - please adjust! ### + op.drop_column('task', 'is_complete') + # ### end Alembic commands ### + + +def downgrade(): + # ### commands auto generated by Alembic - please adjust! ### + op.add_column('task', sa.Column('is_complete', sa.VARCHAR(), autoincrement=False, nullable=True)) + # ### end Alembic commands ### diff --git a/migrations/versions/29c6c544b7b8_.py b/migrations/versions/29c6c544b7b8_.py new file mode 100644 index 000000000..1d624d051 --- /dev/null +++ b/migrations/versions/29c6c544b7b8_.py @@ -0,0 +1,28 @@ +"""empty message + +Revision ID: 29c6c544b7b8 +Revises: 1dabb5ea2f8a +Create Date: 2023-05-10 11:30:33.359925 + +""" +from alembic import op +import sqlalchemy as sa + + +# revision identifiers, used by Alembic. +revision = '29c6c544b7b8' +down_revision = '1dabb5ea2f8a' +branch_labels = None +depends_on = None + + +def upgrade(): + # ### commands auto generated by Alembic - please adjust! ### + op.drop_column('task', 'is_complete') + # ### end Alembic commands ### + + +def downgrade(): + # ### commands auto generated by Alembic - please adjust! ### + op.add_column('task', sa.Column('is_complete', sa.VARCHAR(), autoincrement=False, nullable=True)) + # ### end Alembic commands ### diff --git a/migrations/versions/85f9de15d5b3_.py b/migrations/versions/85f9de15d5b3_.py new file mode 100644 index 000000000..331bcde4d --- /dev/null +++ b/migrations/versions/85f9de15d5b3_.py @@ -0,0 +1,30 @@ +"""empty message + +Revision ID: 85f9de15d5b3 +Revises: b90bd89f93eb +Create Date: 2023-05-11 21:22:56.242161 + +""" +from alembic import op +import sqlalchemy as sa + + +# revision identifiers, used by Alembic. +revision = '85f9de15d5b3' +down_revision = 'b90bd89f93eb' +branch_labels = None +depends_on = None + + +def upgrade(): + # ### commands auto generated by Alembic - please adjust! ### + op.add_column('task', sa.Column('goal_id', sa.Integer(), nullable=True)) + op.create_foreign_key(None, 'task', 'goal', ['goal_id'], ['goal_id']) + # ### end Alembic commands ### + + +def downgrade(): + # ### commands auto generated by Alembic - please adjust! ### + op.drop_constraint(None, 'task', type_='foreignkey') + op.drop_column('task', 'goal_id') + # ### end Alembic commands ### diff --git a/migrations/versions/895aa5ab74ee_.py b/migrations/versions/895aa5ab74ee_.py new file mode 100644 index 000000000..5e4295db8 --- /dev/null +++ b/migrations/versions/895aa5ab74ee_.py @@ -0,0 +1,28 @@ +"""empty message + +Revision ID: 895aa5ab74ee +Revises: 29c6c544b7b8 +Create Date: 2023-05-10 11:42:06.750716 + +""" +from alembic import op +import sqlalchemy as sa + + +# revision identifiers, used by Alembic. +revision = '895aa5ab74ee' +down_revision = '29c6c544b7b8' +branch_labels = None +depends_on = None + + +def upgrade(): + # ### commands auto generated by Alembic - please adjust! ### + op.add_column('task', sa.Column('is_complete', sa.String(), nullable=True)) + # ### end Alembic commands ### + + +def downgrade(): + # ### commands auto generated by Alembic - please adjust! ### + op.drop_column('task', 'is_complete') + # ### end Alembic commands ### diff --git a/migrations/versions/b90bd89f93eb_.py b/migrations/versions/b90bd89f93eb_.py new file mode 100644 index 000000000..9c742b9d3 --- /dev/null +++ b/migrations/versions/b90bd89f93eb_.py @@ -0,0 +1,28 @@ +"""empty message + +Revision ID: b90bd89f93eb +Revises: 28405e468053 +Create Date: 2023-05-11 15:38:43.338784 + +""" +from alembic import op +import sqlalchemy as sa + + +# revision identifiers, used by Alembic. +revision = 'b90bd89f93eb' +down_revision = '28405e468053' +branch_labels = None +depends_on = None + + +def upgrade(): + # ### commands auto generated by Alembic - please adjust! ### + op.add_column('goal', sa.Column('title', sa.String(), nullable=True)) + # ### end Alembic commands ### + + +def downgrade(): + # ### commands auto generated by Alembic - please adjust! ### + op.drop_column('goal', 'title') + # ### end Alembic commands ### diff --git a/requirements.txt b/requirements.txt index 453f0ef6a..dfc239f9f 100644 --- a/requirements.txt +++ b/requirements.txt @@ -1,3 +1,4 @@ +aiohttp==3.8.4 alembic==1.5.4 attrs==20.3.0 autopep8==1.5.5 @@ -28,6 +29,7 @@ python-dotenv==0.15.0 python-editor==1.0.4 requests==2.25.1 six==1.15.0 +slack-sdk==3.21.3 SQLAlchemy==1.3.23 toml==0.10.2 urllib3==1.26.5 diff --git a/tests/test_wave_01.py b/tests/test_wave_01.py index dca626d78..f54bd21fc 100644 --- a/tests/test_wave_01.py +++ b/tests/test_wave_01.py @@ -2,7 +2,7 @@ import pytest -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_tasks_no_saved_tasks(client): # Act response = client.get("/tasks") @@ -13,7 +13,7 @@ def test_get_tasks_no_saved_tasks(client): assert response_body == [] -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_tasks_one_saved_tasks(client, one_task): # Act response = client.get("/tasks") @@ -32,7 +32,7 @@ def test_get_tasks_one_saved_tasks(client, one_task): ] -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_task(client, one_task): # Act response = client.get("/tasks/1") @@ -51,7 +51,7 @@ def test_get_task(client, one_task): } -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_task_not_found(client): # Act response = client.get("/tasks/1") @@ -60,13 +60,8 @@ def test_get_task_not_found(client): # Assert assert response.status_code == 404 - raise Exception("Complete test with assertion about response body") - # ***************************************************************** - # **Complete test with assertion about response body*************** - # ***************************************************************** - -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_create_task(client): # Act response = client.post("/tasks", json={ @@ -93,7 +88,7 @@ def test_create_task(client): assert new_task.completed_at == None -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_update_task(client, one_task): # Act response = client.put("/tasks/1", json={ @@ -119,7 +114,7 @@ def test_update_task(client, one_task): assert task.completed_at == None -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_update_task_not_found(client): # Act response = client.put("/tasks/1", json={ @@ -131,13 +126,8 @@ def test_update_task_not_found(client): # Assert assert response.status_code == 404 - raise Exception("Complete test with assertion about response body") - # ***************************************************************** - # **Complete test with assertion about response body*************** - # ***************************************************************** - -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_delete_task(client, one_task): # Act response = client.delete("/tasks/1") @@ -152,7 +142,7 @@ def test_delete_task(client, one_task): assert Task.query.get(1) == None -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_delete_task_not_found(client): # Act response = client.delete("/tasks/1") @@ -161,15 +151,10 @@ def test_delete_task_not_found(client): # Assert assert response.status_code == 404 - raise Exception("Complete test with assertion about response body") - # ***************************************************************** - # **Complete test with assertion about response body*************** - # ***************************************************************** - assert Task.query.all() == [] -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_create_task_must_contain_title(client): # Act response = client.post("/tasks", json={ @@ -186,7 +171,7 @@ def test_create_task_must_contain_title(client): assert Task.query.all() == [] -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_create_task_must_contain_description(client): # Act response = client.post("/tasks", json={ diff --git a/tests/test_wave_02.py b/tests/test_wave_02.py index a087e0909..651e3aebd 100644 --- a/tests/test_wave_02.py +++ b/tests/test_wave_02.py @@ -1,7 +1,7 @@ import pytest -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_tasks_sorted_asc(client, three_tasks): # Act response = client.get("/tasks?sort=asc") @@ -29,7 +29,7 @@ def test_get_tasks_sorted_asc(client, three_tasks): ] -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_tasks_sorted_desc(client, three_tasks): # Act response = client.get("/tasks?sort=desc") diff --git a/tests/test_wave_03.py b/tests/test_wave_03.py index 32d379822..c325b00e2 100644 --- a/tests/test_wave_03.py +++ b/tests/test_wave_03.py @@ -5,7 +5,7 @@ import pytest -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_mark_complete_on_incomplete_task(client, one_task): # Arrange """ @@ -42,7 +42,7 @@ def test_mark_complete_on_incomplete_task(client, one_task): assert Task.query.get(1).completed_at -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_mark_incomplete_on_complete_task(client, completed_task): # Act response = client.patch("/tasks/1/mark_incomplete") @@ -62,7 +62,7 @@ def test_mark_incomplete_on_complete_task(client, completed_task): assert Task.query.get(1).completed_at == None -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_mark_complete_on_completed_task(client, completed_task): # Arrange """ @@ -99,7 +99,7 @@ def test_mark_complete_on_completed_task(client, completed_task): assert Task.query.get(1).completed_at -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_mark_incomplete_on_incomplete_task(client, one_task): # Act response = client.patch("/tasks/1/mark_incomplete") @@ -119,7 +119,7 @@ def test_mark_incomplete_on_incomplete_task(client, one_task): assert Task.query.get(1).completed_at == None -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_mark_complete_missing_task(client): # Act response = client.patch("/tasks/1/mark_complete") @@ -127,14 +127,15 @@ def test_mark_complete_missing_task(client): # Assert assert response.status_code == 404 + assert response_body == {"message": "1 not found"} - raise Exception("Complete test with assertion about response body") + # raise Exception("Complete test with assertion about response body") # ***************************************************************** # **Complete test with assertion about response body*************** # ***************************************************************** -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_mark_incomplete_missing_task(client): # Act response = client.patch("/tasks/1/mark_incomplete") @@ -142,8 +143,9 @@ def test_mark_incomplete_missing_task(client): # Assert assert response.status_code == 404 + assert response_body == {"message": "1 not found"} - raise Exception("Complete test with assertion about response body") + # raise Exception("Complete test with assertion about response body") # ***************************************************************** # **Complete test with assertion about response body*************** # ***************************************************************** diff --git a/tests/test_wave_05.py b/tests/test_wave_05.py index aee7c52a1..b208a9375 100644 --- a/tests/test_wave_05.py +++ b/tests/test_wave_05.py @@ -1,7 +1,8 @@ import pytest +from app.models.goal import Goal -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_goals_no_saved_goals(client): # Act response = client.get("/goals") @@ -12,7 +13,7 @@ def test_get_goals_no_saved_goals(client): assert response_body == [] -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_goals_one_saved_goal(client, one_goal): # Act response = client.get("/goals") @@ -29,7 +30,7 @@ def test_get_goals_one_saved_goal(client, one_goal): ] -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_goal(client, one_goal): # Act response = client.get("/goals/1") @@ -46,22 +47,23 @@ def test_get_goal(client, one_goal): } -@pytest.mark.skip(reason="test to be completed by student") +# @pytest.mark.skip(reason="test to be completed by student") def test_get_goal_not_found(client): - pass # Act response = client.get("/goals/1") response_body = response.get_json() - raise Exception("Complete test") + # Assert + + # raise Exception("Complete test") # Assert # ---- Complete Test ---- - # assertion 1 goes here - # assertion 2 goes here + assert response.status_code == 404 + assert response_body == {"message": "Goal 1 not found"} # ---- Complete Test ---- -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_create_goal(client): # Act response = client.post("/goals", json={ @@ -80,34 +82,48 @@ def test_create_goal(client): } -@pytest.mark.skip(reason="test to be completed by student") +# @pytest.mark.skip(reason="test to be completed by student") def test_update_goal(client, one_goal): - raise Exception("Complete test") + # raise Exception("Complete test") # Act + response = client.put("/goals/1", json={ + "title": "Updated Goal Title" + }) + response_body = response.get_json() # ---- Complete Act Here ---- # Assert # ---- Complete Assertions Here ---- - # assertion 1 goes here - # assertion 2 goes here - # assertion 3 goes here + assert response.status_code == 200 + assert "goal" in response_body + assert response_body == { + "goal": { + "id": 1, + "title": "Updated Goal Title" + } + } # ---- Complete Assertions Here ---- -@pytest.mark.skip(reason="test to be completed by student") +# @pytest.mark.skip(reason="test to be completed by student") def test_update_goal_not_found(client): - raise Exception("Complete test") + # raise Exception("Complete test") # Act + response = client.put("/goals/1", json={ + "title": "Updated Goal Title" + }) + response_body = response.get_json() + # ---- Complete Act Here ---- # Assert # ---- Complete Assertions Here ---- - # assertion 1 goes here - # assertion 2 goes here + assert response.status_code == 404 + assert response_body == {"message": "Goal 1 not found"} # ---- Complete Assertions Here ---- -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_delete_goal(client, one_goal): # Act response = client.delete("/goals/1") @@ -122,29 +138,35 @@ def test_delete_goal(client, one_goal): # Check that the goal was deleted response = client.get("/goals/1") + response_body = response.get_json() assert response.status_code == 404 + assert response_body == { + "message": "Goal 1 not found" + } - raise Exception("Complete test with assertion about response body") + # raise Exception("Complete test with assertion about response body") # ***************************************************************** # **Complete test with assertion about response body*************** # ***************************************************************** -@pytest.mark.skip(reason="test to be completed by student") +# @pytest.mark.skip(reason="test to be completed by student") def test_delete_goal_not_found(client): - raise Exception("Complete test") + # raise Exception("Complete test") # Act # ---- Complete Act Here ---- + response = client.delete("/goals/1") + response_body = response.get_json() # Assert # ---- Complete Assertions Here ---- - # assertion 1 goes here - # assertion 2 goes here + assert response.status_code == 404 + assert response_body == {"message": "Goal 1 not found"} # ---- Complete Assertions Here ---- -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_create_goal_missing_title(client): # Act response = client.post("/goals", json={}) diff --git a/tests/test_wave_06.py b/tests/test_wave_06.py index 8afa4325e..42da8d964 100644 --- a/tests/test_wave_06.py +++ b/tests/test_wave_06.py @@ -2,7 +2,7 @@ import pytest -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_post_task_ids_to_goal(client, one_goal, three_tasks): # Act response = client.post("/goals/1/tasks", json={ @@ -23,7 +23,7 @@ def test_post_task_ids_to_goal(client, one_goal, three_tasks): assert len(Goal.query.get(1).tasks) == 3 -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_post_task_ids_to_goal_already_with_goals(client, one_task_belongs_to_one_goal, three_tasks): # Act response = client.post("/goals/1/tasks", json={ @@ -42,7 +42,7 @@ def test_post_task_ids_to_goal_already_with_goals(client, one_task_belongs_to_on assert len(Goal.query.get(1).tasks) == 2 -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_tasks_for_specific_goal_no_goal(client): # Act response = client.get("/goals/1/tasks") @@ -51,13 +51,13 @@ def test_get_tasks_for_specific_goal_no_goal(client): # Assert assert response.status_code == 404 - raise Exception("Complete test with assertion about response body") + # raise Exception("Complete test with assertion about response body") # ***************************************************************** # **Complete test with assertion about response body*************** # ***************************************************************** -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_tasks_for_specific_goal_no_tasks(client, one_goal): # Act response = client.get("/goals/1/tasks") @@ -74,7 +74,7 @@ def test_get_tasks_for_specific_goal_no_tasks(client, one_goal): } -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_tasks_for_specific_goal(client, one_task_belongs_to_one_goal): # Act response = client.get("/goals/1/tasks") @@ -99,7 +99,7 @@ def test_get_tasks_for_specific_goal(client, one_task_belongs_to_one_goal): } -@pytest.mark.skip(reason="No way to test this feature yet") +# @pytest.mark.skip(reason="No way to test this feature yet") def test_get_task_includes_goal_id(client, one_task_belongs_to_one_goal): response = client.get("/tasks/1") response_body = response.get_json()