Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Brenda Rios - API-Muncher - Octos #25

Open
wants to merge 51 commits into
base: master
Choose a base branch
from
Open

Brenda Rios - API-Muncher - Octos #25

wants to merge 51 commits into from

Conversation

brendarios
Copy link

@brendarios brendarios commented May 7, 2018 •
edited
Loading

API Muncher

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
How did you go about exploring the Edamam API, how did you try querying the API? I checked the Edamam documentation and used Postman to test request paths.
Describe your API Wrapper. How did you decide on the methods you created? My API Wrapper consists of two methods, list_of_recipes and show_recipe. With the method list_of_recipes using a search term I am able to retrieve a list of recipes, then using its uri I am able to retrieve the details for a specific recipe.
Describe an edge case or failure case test you wrote for your API Wrapper. An edge case I testes was that it returns nil with a bogus recipe uri. Also tested that it returns an error if bogus arguments in the show recipe method.
Explain how VCR aids in testing an API. VCR aids in testing because by saving API responses in the cassettes, it reduces the number of API calls we make.
What is the Heroku URL of your deployed application? https://munchmore.herokuapp.com/
Provide a link to the Trello board you used https://trello.com/b/a6jav2aU/api-muncher

brendarios added 30 commits May 2, 2018 12:39
@brendarios
Created rails folders.
0386a3e
@brendarios
Created edamam api wrapper file and a recipe file in lib.
8020aec
@brendarios
Added .env file with id and key and added .env in the .gitignore file.
8341317
@brendarios
Added line of config.autoload_paths to file application.rb
3b1ffad
@brendarios
Added routes and created recipes controller plus view files.
55f771d
@brendarios
Added gem Kaminari for pagination.
9562e05
@brendarios
Refactored controllers.
7ebb57d
@brendarios
Refactored lib files to show recipes.
0111f6b
@brendarios
Modified views to be able to see recipes.
3d5e6c9
@brendarios
Routes working.
4057b57
@brendarios
Added lines in the test helper to hide the api key and api kid
c2cc579
@brendarios
cleaning controller.
a4e892b
@brendarios
Deleted a gem
590aecd
@brendarios
Updated gem
26576b1
@brendarios
Changed line name
8a245c0
@brendarios
Trying to fix the deployment.
93a3f3c
@brendarios
Added flash message in controller and in the views
c0bc0a3
@brendarios
Trying to do tests.
b9f47e5
@brendarios
refactoring tests.
f2b11c2
@brendarios
Created form file for search bar
d6d32f4
@brendarios
Adding styling to the app.
d822183
@brendarios
Updated gem file
7e66ee7
@brendarios
modified gems.
1f8b479
@brendarios
Cleaning gems file
8a76686
@brendarios
Continued adding styling.
ba2990f
@brendarios
Trying to fix deployemnt.
84e23d5
@brendarios
Changed application configuration.
421928d
@brendarios
removing require pry
30b8cfa
@brendarios
Solved the problem that was not allowing me to run the tests.
117ac5d
@brendarios
fixing again deployment issues.
5d38291
brendarios added 17 commits May 5, 2018 12:16
@brendarios
Tests for class recipe.rb passing
f2f9c80
@brendarios
Tests for recipes controller are passing.
e532223
@brendarios
Cleaninun up tests. All passing =)
219f9f8
@brendarios
Adding styling.
9971730
@brendarios
wondering why heroku didnt take my styling of the homepage.
7a19ac4
@brendarios
Trying to fix why heroku does not update the CSS
aecc5b8
@brendarios
Still trying to fix assets issue with heroku
18501db
@brendarios
Going back, not working assets on heroku.
4b0737a
@brendarios
Working on css and trying to deploy.
f58b2d7
@brendarios
working on css and tryin to deploy them
f9f0e00
@brendarios
I think now heroku is taking care of my css.
91eff5d
@brendarios
Adding more css now that heroku is taking it.
d0d93fe
@brendarios
trying to upload background image to heroku.
2d24f20
@brendarios
Still trying to upload image to heroku.
e3b90dd
@brendarios
Added css to the show page. Heroku likes my background image now.
0679931
@brendarios
Last changes of styling.
357cdea
@brendarios
Cleaning files.
d41277b
@droberts-sea
Copy link

API Muncher

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene yes
Comprehension questions yes
General
Rails fundamentals (RESTful routing, use of named paths) yes
Semantic HTML yes
Errors are reported to the user yes
API Wrapper to handle the API requests yes
Controller testing yes
Lib testing yes
Search Functionality yes
List Functionality yes
Show individual item functionality (link to original recipe opens in new tab) yes
Styling
Responsive layout yes
List View shows 10 items at a time/pagination yes
The app is styled to create an attractive user interface yes
API Features
The App attributes Edaman yes
The VCR casettes do not contain the API key yes
External Resources
Link to Trello Board yes
Link to deployed app on Heroku yes
Overall Great job overall! Your code is well-organized and easy to read, and it's clear the learning goals for this assignment were met. I've left a couple of comments inline, but in general I'm quite happy with this submission. Keep up the hard work!

droberts-sea
droberts-sea reviewed May 8, 2018
View reviewed changes
config/routes.rb
get '/recipes', to: 'recipes#index', as: 'recipes'

# path for showing details of a recipe
get '/recipes/:uri', to: 'recipes#show', as: 'recipe'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you use resources for these two routes?

app/views/layouts/application.html.erb
</body>

<footer>
<h6>Powered by</h6>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The <footer> (and all content that renders on the page) should go inside the <body>

test/controllers/recipes_controller_test.rb

describe "#index" do

it "successfully loads recipe results for any search term" do
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might also be worthwhile to add some tests around the paging parameters:

  • What happens if they're absent?
  • Do you get different results when they change?
  • What if you send a bogus value, like a negative page number?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@droberts-sea droberts-sea droberts-sea left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brendarios @droberts-sea