-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ampers - Maddie Shields #37
base: master
Are you sure you want to change the base?
Conversation
API MuncherWhat We're Looking For
|
<ul> | ||
<% @recipes.each do |recipe| %> | ||
<li> | ||
<%= image_tag(recipe.image) %> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Making the image a clickable link would improve the user experience.
@@ -0,0 +1,18 @@ | |||
<h1> Results for "<%= @query %>"</h1> | |||
<div class=""> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What purpose does this div
element serve?
end | ||
|
||
describe "show_recipe" do | ||
it "can show a single recipe" do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about the negative case here? What about if the URI is wrong?
|
||
class ActiveSupport::TestCase | ||
# Setup all fixtures in test/fixtures/*.yml for all tests in alphabetical order. | ||
fixtures :all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
VCR configuration?
API Muncher
Congratulations! You're submitting your assignment!
Comprehension Questions