-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kat - Inspiration-Board - Octos #27
base: master
Are you sure you want to change the base?
Conversation
Inspiration BoardWhat We're Looking For
|
@@ -0,0 +1,3 @@ | |||
// ./__mocks__/axios.js | |||
import mockAxios from 'jest-mock-axios'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Outstanding!
this.props.updateStatusCallback(error.message, 'error') | ||
}) | ||
|
||
axios.get(BASE_URL) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do 2 API calls?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forgot to refactor after implementing the functionality to allow a user to change the inspiration board. I was following the whole "make it work, make it right, make it pretty" mantra. It works, but it is not right or pretty. :*(
Inspiration Board
Congratulations! You're submitting your assignment!
Comprehension Questions