-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Selam - Ampers #34
base: master
Are you sure you want to change the base?
Selam - Ampers #34
Conversation
import './Card.css'; | ||
|
||
function convertToemoji(anEmoji){ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
proper camel case would be convertToEmoji
class Card extends Component { | ||
findID = () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not a very great function name, maybe something like just deleteCard
would be better
Inspiration BoardWhat We're Looking For
Overall, looks good -- my only comments would be on naming conventions. Good job on this project! |
import emoji from 'emoji-dictionary'; | ||
import './NewCardForm.css'; | ||
|
||
const EMOJI_LIST = ["", "heart_eyes", "beer", "clap", "sparkling_heart", "heart_eyes_cat", "dog"] | ||
|
||
|
||
class NewCardForm extends Component { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
watch your indentation throughout this entire component!
Inspiration Board
Congratulations! You're submitting your assignment!
Comprehension Questions