Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Personal Portfolio - Angela - Octos #22

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

knockknockhusthere
Copy link

@knockknockhusthere knockknockhusthere commented Mar 19, 2018

Personal Portfolio Site

Congratulations! You're submitting your assignment!
I promise I had more commits/pushes, my computer just didn't track them. Also I realize my h2 font got overridden on some of the pages because I didn't link the google font - I ended up liking the font family that it defaulted to!

Comprehension Questions

Question Answer
Did you have to resolve any issues when running the HTML Validator? If so, what were they? it suggested headers on some of my divs.
Why is it important to consider and use semantic HTML? Its easier to go back and figure out your own work, as well as for other people to be able to understand it later on. Increasing clarity will make your site accessible to more people down the line.
How did you decide to structure your CSS? I originally had a main css file and one for each page besides the homepage, in hopes that some styles would cascade through. It turned out to cause more trouble and makes the rest of my css more convoluted just by trying to cancel out what the main file was doing. Didn't have time to change it but would make that change later on.
What was the most challenging piece of this assignment? Keeping the CSS files straight and figuring out when it was CSS's native behavior and when it was cause by my main css file.
Describe one area that you gained more clarity on when completing this assignment
Optional
Did you deploy to GitHub Pages? If so, what is the URL to your website?
Overall

@tildeee
Copy link

tildeee commented Apr 5, 2018

Personal Portfolio Site

What We're Looking For

Feature Feedback
Baseline
Appropriate Git Usage x, though some of the commits aren't tied to your account. If this keeps happening, let an instructor know so we can fix it!
Answered comprehension questions last question you didn't answer :O
Page fully loads x
No broken links (regular or images) x
Includes at least 4 pages and styling x
HTML
Uses the high-level tags for organization: header, footer, main x
Appropriately using semantic tags: section, article, etc. x
All images include alternate text x
CSS
Using class and ID names in style declarations x
Style declarations are DRY x
Overall

Kim Possible jingle aggressively plays

lololol anyway--

I have no comments! Looks good overall! Good work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants