Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ampers: Nora Peters #26

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Ampers: Nora Peters #26

wants to merge 6 commits into from

Conversation

npeters5
Copy link

Personal Portfolio Site

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Did you have to resolve any issues when running the HTML Validator? If so, what were they? Just a typo in my target=_blank inside an tag.
Why is it important to consider and use semantic HTML? So that the code speaks for itself and if someone else needed to refactor it, they can tell by the section names what each is meant to do.
How did you decide to structure your CSS? I tried to be the least specific at the top, and more specific toward the bottom. I also arranged the CSS rules in order of how the elements appear in my HTML doc.
What was the most challenging piece of this assignment? Layout. Always layout. And centering flex and grid items. I also struggled a lot with SVGs and trying to insert them as background images through CSS. Eventually had to convert to png and insert in HTML.
Describe one area that you gained more clarity on when completing this assignment CSS in general, and also how to better use Developer Tools to troubleshoot why something isn't working. Flex and Grid are still a bit mysterious but overall I think I understand them better after this project.
Optional
Did you deploy to GitHub Pages? If so, what is the URL to your website? I will soon to norapeters.com
Overall

@tildeee
Copy link

tildeee commented Apr 2, 2018

Personal Portfolio Site

What We're Looking For

Feature Feedback
Baseline
Appropriate Git Usage x
Answered comprehension questions x
Page fully loads x
No broken links (regular or images) x
Includes at least 4 pages and styling content empty on about page and blog page
HTML
Uses the high-level tags for organization: header, footer, main x
Appropriately using semantic tags: section, article, etc.
All images include alternate text x
CSS
Using class and ID names in style declarations x
Style declarations are DRY x
Overall

NORA IT LOOKS SO GOOOOOD! The cards and the tags (skills on the front page) look particularly incredible and polished! But also that front page looks so great ✨

I learned a lot about the <picture> tag through your code! thank you!

this project would have been better if there were content in the about and blog pages

Either way, overall the code looks good and the site looks good. Great job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants