Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Caroline - Personal Portfolio Site - Octos #28

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

cmn53
Copy link

@cmn53 cmn53 commented Mar 19, 2018

Personal Portfolio Site

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Did you have to resolve any issues when running the HTML Validator? If so, what were they? The HTML validator didn't like the 'or' symbol that the Google Fonts API used to combine two fonts into one link. This seemed like a pretty minor thing (and not really part of the HTML) so I left it in.
Why is it important to consider and use semantic HTML? It provides clarity for whoever else might look at the page's structure, and is important for providing accessibility for those that rely on screen readers to navigate the internet.
How did you decide to structure your CSS? The CSS for the navigation, footer, and commonly used font sizes and styles is included in the gen.css file, while the CSS that applies only to a single page is included in a CSS file with the same name as the page. There is some overlap between the blog and projects sites that could probably be consolidated, either in the gen.css or another file.
What was the most challenging piece of this assignment? I spent a long time trying to figure out how to get two grid items to overlay each other in the same grid space, specifically an image and text with a transparent background. I eventually figured out that using a background image was the easiest way to achieve this, although it seemed more like a work-around than actually figuring out the overlay issue.
Describe one area that you gained more clarity on when completing this assignment Because I primarily used Flexbox on the Startrly project, I really wanted to use CSS grid for this project so I would feel more comfortable with it. I ended up making a much larger grid than I probably needed, but because the navigation bar had already been formatted using this larger grid, I maintained it for the rest of the site. In the future I think I would try to map out the site a little bit more before starting to figure out how many columns I would really need.
Optional
Did you deploy to GitHub Pages? If so, what is the URL to your website? no
Overall

@droberts-sea
Copy link

Personal Portfolio Site

What We're Looking For

Feature Feedback
Baseline
Appropriate Git Usage yes
Answered comprehension questions yes
Page fully loads yes
No broken links (regular or images) yes
Includes at least 4 pages and styling yes
HTML
Uses the high-level tags for organization: header, footer, main some - I see <footer>s, but you should group all the content at the top of your page in a <header>, and everything between the two in <main> (the blog page does a good job of this).
Appropriately using semantic tags: section, article, etc. yes
All images include alternate text yes
CSS
Using class and ID names in style declarations yes
Style declarations are DRY yes - good use of multiple files to keep things DRY.
Overall Great work overall! Site is attractive and easy to navigate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants