Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated html and css #34

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

updated html and css #34

wants to merge 1 commit into from

Conversation

steffnay
Copy link

@steffnay steffnay commented Mar 19, 2018

Personal Portfolio Site

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Did you have to resolve any issues when running the HTML Validator? If so, what were they? I had an issue with having p inside of sub, which I didn't realize wasn't accepted syntax. While trying to fix this issue, I came up against some struggles with figuring out which tags to use and ended up using the unholy div!
Why is it important to consider and use semantic HTML? It makes your site easier to update, more accessible to screen readers, and more easily found by search engines
How did you decide to structure your CSS? I tried to use ids more than the nested tags because that made the pieces more clear to me.
What was the most challenging piece of this assignment? DRYing up my CSS. I feel like it could be a lot better, but I struggled to figure out which areas I could condense more. It was also difficult to figure out how to manage the consistency between pages.
Describe one area that you gained more clarity on when completing this assignment I learned a lot more about using flexbox and CSS grid together.
Optional
Did you deploy to GitHub Pages? If so, what is the URL to your website?
Overall

@tildeee
Copy link

tildeee commented Apr 2, 2018

Personal Portfolio Site

What We're Looking For

Feature Feedback
Baseline
Appropriate Git Usage only one commit!
Answered comprehension questions x
Page fully loads
No broken links (regular or images) x
Includes at least 4 pages and styling x
HTML
Uses the high-level tags for organization: header, footer, main x
Appropriately using semantic tags: section, article, etc. you use divs a lot, particularly in the project page and the about page
All images include alternate text x
CSS
Using class and ID names in style declarations x
Style declarations are DRY x
Overall

A lot of your IDs/classes use underscores. It’s convention to declare classes and ids hyphenated (kebab-case)

For the problem you encountered about DRYing up the styles-- maybe you could have put a lot of the repeated styles in one file and imported that file in each page, just like you did with normalize.css

Looks good and the code looks good! great job

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants