Solution with gemini #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Realized I never left any indication I looked at this 😬 Thank you so much for getting these updates done, it's looking great!
The only thing that caught my eye is extremely minor around ordering that already existed in add_greetings where we call generate_greetings before checking if character_obj.greetings already has values.
app/routes/character_routes.py
Outdated
| @@ -83,15 +77,12 @@ def add_greetings(char_id): | |||
| return make_response(jsonify(f"Greetings successfully added to {character_obj.name}"), 201) | |||
|
|
|||
| def generate_greetings(character): | |||
| model = genai.GenerativeModel("gemini-1.5-flash") | |||
| input_message = f"I am writing a rantasy RPG video game. I have an npc named {character.name} who is {character.age} years old. They are a {character.occupation} who has a {character.personality} personality. Please generate a python style list of 10 stock phrases they might use when the main character talks to them. Please Return just the list without a variable name and square brackets." | |||
There was a problem hiding this comment.
Suggested change
| input_message = f"I am writing a rantasy RPG video game. I have an npc named {character.name} who is {character.age} years old. They are a {character.occupation} who has a {character.personality} personality. Please generate a python style list of 10 stock phrases they might use when the main character talks to them. Please Return just the list without a variable name and square brackets." | |
| input_message = f"I am writing a fantasy RPG video game. I have an npc named {character.name} who is {character.age} years old. They are a {character.occupation} who has a {character.personality} personality. Please generate a Python style list of 10 stock phrases they might use when the main character talks to them. Please return just the list without a variable name and square brackets." |
app/routes/character_routes.py
Outdated
| @@ -83,15 +77,12 @@ def add_greetings(char_id): | |||
| return make_response(jsonify(f"Greetings successfully added to {character_obj.name}"), 201) | |||
There was a problem hiding this comment.
We could remove jsonify through the project
Solution: remove jsonify and directly return data structures following Unit 2 Patterns
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.