-
Notifications
You must be signed in to change notification settings - Fork 710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Amethyst-C19-Kaliane-Van-JS-Adagrams #55
base: main
Are you sure you want to change the base?
Conversation
export const drawLetters = () => { | ||
// Implement this method for wave 1 | ||
const letterPool = { | ||
'A': 9, 'B': 2, 'C': 2, 'D': 4, 'E': 12,'F': 2, | ||
'G': 3, 'H': 2, 'I': 9, 'J': 1, 'K': 1, 'L': 4, | ||
'M': 2, 'N': 6, 'O': 8, 'P': 2, 'Q': 1, 'R': 6, | ||
'S': 4, 'T': 6, 'U': 4, 'V': 2, 'W': 2, 'X': 1, | ||
'Y': 2, 'Z': 1 | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Kaliane! Great job completing JS Adagrams! Congrats on finishing your first JavaScript project 🎉 Excellent choice with this data structure, I just want to mention that in JavaScript our keys don't need to be strings. Because of the popularity of JSON, it is frequent to see the keys of object literals as quoted strings. The quotes are required in order to be valid JSON, but they are not required in order to be valid JavaScript. Keys in object literals can be expressed in any of the following three ways:
const letterValue = {
A: 9, // No quotes at all
'A': 9, // Single-quoted string
"A": 9 // Double-quoted string
};
let letters = []; | ||
for (let letter in letterPool) { | ||
for (let i = 0; i < letterPool[letter]; i++) { | ||
letters.push(letter); | ||
} | ||
} | ||
|
||
let hand = []; | ||
for (let i = 0; i < 10; i++) { | ||
let randomIndex = Math.floor(Math.random() * letters.length); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work getting comfortable with JavaScript's syntax. It looks like you're getting use to looping over data and adding conditional logic ✅
export const usesAvailableLetters = (input, lettersInHand) => { | ||
// Implement this method for wave 2 | ||
let lettersInHandCopy = [...lettersInHand]; | ||
for (let letter of input) { | ||
if (!lettersInHandCopy.includes(letter)) { | ||
return false; | ||
} else { | ||
let index = lettersInHandCopy.indexOf(letter); | ||
lettersInHandCopy.splice(index, 1); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
let score = 0; | ||
|
||
for (let letter of word.toUpperCase()) { | ||
score += letterScores[letter]; | ||
} | ||
|
||
if (word.length >= 7) { | ||
score += 8; | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job translating this logic 👍🏾
if (score > highestScore) { | ||
highestScore = score; | ||
highestScoringWord = word; | ||
} else if (score === highestScore) { | ||
if (word.length === 10 && highestScoringWord.length !== 10) { | ||
highestScoringWord = word; | ||
} else if (word.length < highestScoringWord.length && highestScoringWord.length !== 10) { | ||
highestScoringWord = word; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work with these variable names!
No description provided.