Lions C18 LP Wilson Swap Meet #21
Conversation
There was a problem hiding this comment.
Excellent job! Your code overall was great. There were a few places where the code could be simpler/cleaner. See comments below.
For commits, it would be great if the commit messages could be more descriptive. Instead of writing about which wave was completed, consider messages like "Created Item class" or "Added swap_items function".
|
|
||
| class Clothing(Item): | ||
| def __init__(self, category = "Clothing", condition = 0.0): |
There was a problem hiding this comment.
We actually do not want to have category in the __init__ function. We want the category to always be "Clothing", but if we put category here, the user can set category to whatever they want, which isn't good!
| from swap_meet.item import Item | ||
|
|
||
| class Decor(Item): |
| pass | ||
| from swap_meet.item import Item | ||
|
|
||
| class Electronics(Item): |
| @@ -1,2 +1,17 @@ | |||
| class Item: | |||
| methods: .add(item), .remove(item), .get_by_category(category), | ||
| swap_items(swapping_vendor, my_item, their_item)""" | ||
| def __init__(self, inventory = None): |
| assert item_a not in items | ||
| assert item_b not in items | ||
| assert item_c not in items |
There was a problem hiding this comment.
Great asserts! These are actually not needed though. Based on the first assert, we know the list is empty. We don't need to check that each of these individual items are in the list.
| #assert | ||
| assert result | ||
| assert len(tai.inventory) == 3 | ||
| assert len(jesse.inventory) == 3 | ||
|
|
||
| assert item_f in tai.inventory | ||
| assert item_a in tai.inventory | ||
| assert item_b in tai.inventory | ||
|
|
||
| @pytest.mark.skip | ||
| assert item_c in jesse.inventory | ||
| assert item_d in jesse.inventory | ||
| assert item_e in jesse.inventory |
| assert result | ||
| assert len(tai.inventory) == 3 | ||
| assert len(jesse.inventory) == 3 | ||
|
|
||
| assert item_f in tai.inventory | ||
| assert item_a in tai.inventory | ||
| assert item_b in tai.inventory | ||
| assert item_c not in tai.inventory | ||
|
|
||
| @pytest.mark.skip | ||
| assert item_c in jesse.inventory | ||
| assert item_d in jesse.inventory | ||
| assert item_e in jesse.inventory | ||
| assert item_f not in jesse.inventory |
| assert not result | ||
| assert len(tai.inventory) == 3 | ||
| assert len(jesse.inventory) == 3 | ||
| assert item_a in tai.inventory | ||
| assert item_b in tai.inventory | ||
| assert item_c in tai.inventory | ||
| assert item_d in jesse.inventory | ||
| assert item_e in jesse.inventory | ||
| assert item_f in jesse.inventory |
| assert not result | ||
| assert len(tai.inventory) == 3 | ||
| assert len(jesse.inventory) == 3 | ||
| assert item_a in tai.inventory | ||
| assert item_b in tai.inventory | ||
| assert item_c in tai.inventory | ||
| assert item_d in jesse.inventory | ||
| assert item_e in jesse.inventory | ||
| assert item_f in jesse.inventory |
No description provided.