Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: setting for text file association by file suffix #85

Open
jcsahnwaldt opened this issue Nov 14, 2023 · 2 comments
Open

feat: setting for text file association by file suffix #85

jcsahnwaldt opened this issue Nov 14, 2023 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@jcsahnwaldt
Copy link

jcsahnwaldt commented Nov 14, 2023

Is your feature request related to a problem? Please describe.
It's great that I can quickly create an issue to request file type support, but it would also be great if I could change my local settings to tell Zip Viewer that files with a certain extension are text files.

Describe the solution you'd like
I'd like to add something like "zipViewer.textFileAssociations": [ "*.foo" ] to my user or workspace settings to make Zip Viewer always treat these files as text files.

Describe alternatives you've considered
There already is a zipViewer.textFileAssociations setting, but it doesn't seem to understand *.foo or *.zip wildcards, so I'd have to add an entry for each .foo file in each zip file, which isn't practical if I have many such files.

I don't know the internals of VS Code, but maybe there's a global file type registry that Zip Viewer could access? For example, other extensions already know that .gradle files are text files, but Zip Viewer doesn't.

@jcsahnwaldt jcsahnwaldt added the enhancement New feature or request label Nov 14, 2023
@AdamRaichu AdamRaichu added help wanted Extra attention is needed good first issue Good for newcomers labels Nov 14, 2023
@AdamRaichu
Copy link
Owner

Could you give an example of an extension that recognizes text files automatically? I'm aware that vscode itself checks to see if a file is a text file when you open it, but if there is some registry I am not aware of it. It makes sense that one would exist, but...

I did also search the vscode extension api docs for things like file type, type, file extension, etc. but didn't find anything like that :(.

As for a textFileAssociations-like setting for file types, I think that's a great idea! I'll take a look at that at some point, or someone else is welcome to make a pull request; it doesn't seem that difficult to implement.

@AdamRaichu
Copy link
Owner

@jcsahnwaldt, @dox-exon, @KingNucifera, @LiveFreeAndRoam, and @giac-fab.

I'm sorry for the delay in addressing your issues. I have been working on other projects lately, but rest assured, I have not forgotten about this one! I intend to work on these in the near future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
Development

No branches or pull requests

2 participants