Update auxiliaryfunctions.py and double angles #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update auxiliaryfunctions.py and double angles
using the following data
joints_dict['Nearfrontfoot'] = ['Shoulder', 'Nearfrontfoot', 'Stifle']
x y z (liklehood)
Shoulder 649.29443 355.67105 0.31627
Nearfrontfoot 604.79279 555.68231 0.92415
Stifle 519.55591 358.85684 0.03888
Existing Code
q shortest rotation -0.002116213557255 -0.003361624154413 0.951158771281366
quaternion angle -0.242500855 -0.38521442 144.037938
quaternion scaler 0.22098 0.21534 0.21723
angle_rotation_quaternion 144.041017105924 degrees
Modified Code
q shortest rotation 0.000686756082122 0.001090930770238 -0.308673859961963
quaternion angle 0.0786972977 0.125011118 -35.9586586
quaternion scaler 0.83145863 0.83615687 0.83452721
angle_rotation_quaternion 35.9589828940757 degrees
Second change in double angles reflects above plus calculating padj correctly
Update auxiliaryfunctions.py and double angles
using the following data
joints_dict['Nearfrontfoot'] = ['Shoulder', 'Nearfrontfoot', 'Stifle']
x y z (liklehood)
Shoulder 649.29443 355.67105 0.31627
Nearfrontfoot 604.79279 555.68231 0.92415
Stifle 519.55591 358.85684 0.03888
Existing Code
q shortest rotation -0.002116213557255 -0.003361624154413 0.951158771281366
quaternion angle -0.242500855 -0.38521442 144.037938
quaternion scaler 0.22098 0.21534 0.21723
angle_rotation_quaternion 144.041017105924 degrees
Modified Code
q shortest rotation 0.000686756082122 0.001090930770238 -0.308673859961963
quaternion angle 0.0786972977 0.125011118 -35.9586586
quaternion scaler 0.83145863 0.83615687 0.83452721
angle_rotation_quaternion 35.9589828940757 degrees
Second change in double angles reflects above plus calculating padj correctly
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
jeylau
reviewed
Dec 12, 2023
There was a problem hiding this comment.
Thanks @TedBrierley, this looks good to me! I have just suggested one minor change to make to improve the calculation of the arc tangent.
|
I agree with the suggested change. |
|
Thanks once again @TedBrierley! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.Update auxiliaryfunctions.py
using the following data
joints_dict['Nearfrontfoot'] = ['Shoulder', 'Nearfrontfoot', 'Stifle']
Shoulder 649.29443 355.67105 0.31627
Nearfrontfoot 604.79279 555.68231 0.92415
Stifle 519.55591 358.85684 0.03888
Existing Code
q shortest rotation -0.002116213557255 -0.003361624154413 0.951158771281366
quaternion angle -0.242500855 -0.38521442 144.037938
quaternion scaler 0.22098 0.21534 0.21723
angle_rotation_quaternion 144.041017105924 degrees
Modified Code
q shortest rotation 0.000686756082122 0.001090930770238 -0.308673859961963
quaternion angle 0.0786972977 0.125011118 -35.9586586
quaternion scaler 0.83145863 0.83615687 0.83452721
angle_rotation_quaternion 35.9589828940757 degrees