You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, the customUnits feature carries the al the way to the graph.
This is not really the way we should do things. In this commit, we keep the angle brackets during the UUC conversion.
We should actually remove the angle brackets before adding back the custom units, so that "kg" would become "frogs*kg" at the end. However, if we did that, we would need to keep track of the customUnits internally because otherwise if we tried to add another dataset (or download the json file) we would not know which units were customUnits. So there would need to be some careful logic of adding custom units in a bunch of places. For now, we will just keep the < > because it is not such a big problem to carry the < > everywhere.
The text was updated successfully, but these errors were encountered:
Currently, the customUnits feature carries the al the way to the graph.
This is not really the way we should do things. In this commit, we keep the angle brackets during the UUC conversion.
71be34b
We should actually remove the angle brackets before adding back the custom units, so that "kg" would become "frogs*kg" at the end. However, if we did that, we would need to keep track of the customUnits internally because otherwise if we tried to add another dataset (or download the json file) we would not know which units were customUnits. So there would need to be some careful logic of adding custom units in a bunch of places. For now, we will just keep the < > because it is not such a big problem to carry the < > everywhere.
The text was updated successfully, but these errors were encountered: