Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CustomUnits #6

Open
AdityaSavara opened this issue Nov 27, 2022 · 0 comments
Open

CustomUnits #6

AdityaSavara opened this issue Nov 27, 2022 · 0 comments
Labels
enhancement New feature or request wontfix This will not be worked on

Comments

@AdityaSavara
Copy link
Owner

Currently, the customUnits feature carries the al the way to the graph.
This is not really the way we should do things. In this commit, we keep the angle brackets during the UUC conversion.

71be34b

We should actually remove the angle brackets before adding back the custom units, so that "kg" would become "frogs*kg" at the end. However, if we did that, we would need to keep track of the customUnits internally because otherwise if we tried to add another dataset (or download the json file) we would not know which units were customUnits. So there would need to be some careful logic of adding custom units in a bunch of places. For now, we will just keep the < > because it is not such a big problem to carry the < > everywhere.

@AdityaSavara AdityaSavara added enhancement New feature or request wontfix This will not be worked on labels Nov 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant