Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(nordvpn) Don't launch after install/upgrade #298

Closed
TheCakeIsNaOH opened this issue Jan 22, 2021 · 5 comments
Closed

(nordvpn) Don't launch after install/upgrade #298

TheCakeIsNaOH opened this issue Jan 22, 2021 · 5 comments

Comments

@TheCakeIsNaOH
Copy link
Contributor

Is your feature request related to a problem? Please describe.

I don't like having the NordVPN window pop up when I am running upgrades.

Describe the solution you'd like

For NordVPN to not start after upgrade/install.

Describe alternatives you've considered

N/A

Additional context

I haven't dug into the installer, it is possible they have a flag to disable starting after install. Otherwise, Remove-Process probably would work.

@AdmiringWorm
Copy link
Owner

Unfortunately, the installer do not include any flags to disable the launching of nordvpn (or at least didn't last time I checked).

I am also a bit hesitant to blindly closing the program/process due to the nature of the program, and due to a certain feature available in nordvpn.

  1. Since this is a VPN program, it is more likely that a user wishes to have the program running after installation/upgrading.
  2. Since NordVPN have a feature called KillSwitch (I think that was the name), this can cause issues on a users computer if the program never isn't kept running after installation. It would mean that the user can not connect to the internet after upgrading.

With that said though, there is a possibility that something can be included if the program didn't run before trying to upgrade NordVPN and is something I could look at. But not yet had the chance to look into this yet.

@AdmiringWorm AdmiringWorm added feature A new non-breaking change that adds functionality to a package triage Cause is not known yet/Decision to implement have not been decided labels Feb 13, 2021
@TheCakeIsNaOH
Copy link
Contributor Author

Fair enough on the not wanting to blindly close.

It should be doable to do a Get-Process before install to check if it is running, and after install do Remove-Process if it was not previously running.

@AdmiringWorm
Copy link
Owner

I am thinking.

  1. In chocolateyBeforeModify, add a small metafile (basically a small file with basic information for the future) in the temp directory if the program is already launched.
  2. If the metafile does not exist, remove/close the nordvpn process
  3. Remember to remove the metafile.

That isn't something I have tested if it would work as expected yet though.

@stale
Copy link

stale bot commented Jan 9, 2022

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

@stale stale bot added the wontfix Code is working as expected label Jan 9, 2022
@AdmiringWorm AdmiringWorm removed the wontfix Code is working as expected label Feb 9, 2022
@AdmiringWorm AdmiringWorm changed the title NordVPN - Don't launch after install/upgrade (NordVPN) Don't launch after install/upgrade Apr 27, 2022
@AdmiringWorm AdmiringWorm changed the title (NordVPN) Don't launch after install/upgrade (nordvpn) Don't launch after install/upgrade Apr 27, 2022
@AdmiringWorm
Copy link
Owner

NordVPN will be dropped from this repository, see RFM request: chocolatey-community/chocolatey-package-requests#1454

@AdmiringWorm AdmiringWorm closed this as not planned Won't fix, can't repro, duplicate, stale Oct 1, 2023
@AdmiringWorm AdmiringWorm removed feature A new non-breaking change that adds functionality to a package triage Cause is not known yet/Decision to implement have not been decided labels Oct 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants