From a94f069b999a683e34612e0a39fc359312ccc97e Mon Sep 17 00:00:00 2001 From: Leonard de Ruijter <3049216+LeonarddeR@users.noreply.github.com> Date: Tue, 10 Dec 2024 03:56:39 +0100 Subject: [PATCH] Respect 'Say all on page load' in PowerPoint slide shows (#17488) Summary of the issue: When Browse mode setting "say all on page load" is disabled, NVDA yet starts say all in a slide show. Description of user facing changes NVDA no longer automatically starts say all when starting a PowerPoint slide show and "say all on page load" is disabled. Description of development approach Check the config setting. --- source/appModules/powerpnt.py | 3 +++ user_docs/en/changes.md | 3 ++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/source/appModules/powerpnt.py b/source/appModules/powerpnt.py index 77e09b89281..211576accea 100644 --- a/source/appModules/powerpnt.py +++ b/source/appModules/powerpnt.py @@ -15,6 +15,7 @@ import ctypes import comtypes.client.lazybind +import config import oleacc import comHelper import ui @@ -1386,8 +1387,10 @@ def __contains__(self, obj): def event_treeInterceptor_gainFocus(self): braille.handler.handleGainFocus(self) self.rootNVDAObject.reportFocus() + doSayAll = not self.hadFocusOnce and config.conf["virtualBuffers"]["autoSayAllOnPageLoad"] if not self.hadFocusOnce: self.hadFocusOnce = True + if doSayAll: self.reportNewSlide() else: info = self.selection diff --git a/user_docs/en/changes.md b/user_docs/en/changes.md index 1510ff4e0d8..7071a44cf51 100644 --- a/user_docs/en/changes.md +++ b/user_docs/en/changes.md @@ -52,9 +52,10 @@ To use this feature, "allow NVDA to control the volume of other applications" mu * Math reading has been fixed for some web elements. Specifically, MathML inside of span and other elements that have the attribute `role="math"`. (#15058) * Native support for the Dot Pad tactile graphics device from Dot Inc as a multiline braille display. (#17007) -* Improvements when editing in Microsoft PowerPoint: +* Improvements in Microsoft PowerPoint: * Caret reporting no longer breaks when text contains wide characters, such as emoji. (#17006 , @LeonarddeR) * Character location reporting is now accurate (e.g. when pressing `NVDA+Delete`. (#9941, @LeonarddeR) + * NVDA no longer starts say all when starting a slide show and the browse mode setting "Automatic Say All on page load" is disabled. (#17488, @LeonarddeR) * When using the Seika Notetaker, space and space with dots gestures are now displayed correctly in the Input Gestures dialog. (#17047, @school510587) * Configuration profiles: * Braille is no longer dysfunctional when activating 'say all' with an associated configuration profile. (#17163, @LeonarddeR)