Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rationalize countable refresh_period #58

Open
Aerendir opened this issue Sep 4, 2020 · 0 comments
Open

Rationalize countable refresh_period #58

Aerendir opened this issue Sep 4, 2020 · 0 comments
Labels
[Lang] PHP [Severity] Critical [Status] RFC [Type] Bug [Type] Upgrade
Milestone
0.13.0

Comments

@Aerendir
Copy link
Owner

Aerendir commented Sep 4, 2020

It seems there is logic hole: we set the refresh period in refresh_period, but then we can set both a monthly and a yearly price.
This seems not logical.

The renew period should depend on the what the customer bought.

So, it seems that refresh_period has to be removed at all.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Lang] PHP [Severity] Critical [Status] RFC [Type] Bug [Type] Upgrade
Projects
None yet
Milestone
0.13.0
Development

No branches or pull requests
1 participant
@Aerendir