Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unsafe implementation of WebView SSL Error Handler #1970

Closed
1 of 5 tasks
mohadel92 opened this issue Aug 22, 2024 · 8 comments
Closed
1 of 5 tasks

unsafe implementation of WebView SSL Error Handler #1970

mohadel92 opened this issue Aug 22, 2024 · 8 comments
Labels
waiting for customer response waiting for customer response, or closed by no-reponse bot

Comments

@mohadel92
Copy link

mohadel92 commented Aug 22, 2024

Version of the agora_rtc_engine

agora_rtc_engine 6.3.0
with flutter package
agora_uikit

Platforms affected

  • Android
  • iOS
  • macOS
  • Windows
  • Web

Steps to reproduce

To Reproduce
Steps to reproduce the behavior:

  1. use agora package: agora_uikit
  2. build your app
  3. create your release
  4. Submit your release for review

Expected results

App should pass the review of Google Play Console

Actual results

The app is rejected due to issue with " unsafe implementation of WebView SSL Error Handler"

Code sample

No response

Screenshots or Video

error_route Screenshot 2024-08-22 at 3 29 44 PM

Logs

No response

Flutter Doctor output

Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 3.22.3, on macOS 14.4.1 23E224 darwin-x64, locale en-EG)
[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
[✓] Xcode - develop for iOS and macOS (Xcode 15.4)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2023.3)
[✓] VS Code (version 1.92.2)
[✓] Connected device (2 available)

@littleGnAl
Copy link
Contributor

littleGnAl commented Aug 23, 2024

I checked the package name io.agora.online.component.teachaids, and it is not from our package, I think it's better to check the dependencies in your project and see where it comes from, and raise an issue to that package repo.

@littleGnAl littleGnAl added the waiting for customer response waiting for customer response, or closed by no-reponse bot label Aug 23, 2024
@mohadel92
Copy link
Author

@littleGnAl
this project used to use agora flexible android sdk via flutter
and they removed this integration completely
could it be the reason for such issue?
and how to debug or remove all the sdk remnants ?

@github-actions github-actions bot removed the waiting for customer response waiting for customer response, or closed by no-reponse bot label Aug 26, 2024
@mohadel92
Copy link
Author

@littleGnAl
Kindly i need some help regarding this issue
i was asked by agora support team to. use this native code

 override fun onCreate(savedInstanceState: Bundle?) {
        super.onCreate(savedInstanceState)
        
        // If you're adding a WebView, you would do it like this:
       // val webView = WebView(this)
        setContentView(webView) // Make the WebView the content view, or add it to your layout

        webView.webViewClient = object : WebViewClient() {
            override fun onReceivedSslError(view: WebView, handler: SslErrorHandler, error: SslError) {
                handler.cancel() // Cancel the request if there is an SSL error
            }
        }

        webView.loadUrl("https://your-secure-url.com")
    }

will this code be enough to handle such issue ?

@littleGnAl
Copy link
Contributor

I think you should ask the library owner to fix this issue.

@littleGnAl littleGnAl added the waiting for customer response waiting for customer response, or closed by no-reponse bot label Sep 4, 2024
@mohadel92
Copy link
Author

whom to ask @littleGnAl

@github-actions github-actions bot removed the waiting for customer response waiting for customer response, or closed by no-reponse bot label Sep 4, 2024
@littleGnAl
Copy link
Contributor

Where did you get this package io.agora.online.component.teachaids, you should ask them to fix it.

@littleGnAl littleGnAl added the waiting for customer response waiting for customer response, or closed by no-reponse bot label Sep 5, 2024
Copy link
Contributor

Without additional information, we are unfortunately not sure how to resolve this issue. We are therefore reluctantly going to close this bug for now. If you find this problem please file a new issue with the same description, what happens, logs and the output. All system setups can be slightly different so it's always better to open new issues and reference the related ones. Thanks for your contribution.

Copy link
Contributor

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please raise a new issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
waiting for customer response waiting for customer response, or closed by no-reponse bot
Projects
None yet
Development

No branches or pull requests

2 participants