Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new pin icons #240

Closed
Julieta253 opened this issue Mar 11, 2024 · 2 comments · Fixed by #242
Closed

new pin icons #240

Julieta253 opened this issue Mar 11, 2024 · 2 comments · Fixed by #242
Assignees
@blackfalcon @michelle-alaskaair
Labels
icons

Comments

@Julieta253
Copy link

Julieta253 commented Mar 11, 2024 •
edited
Loading

New pin icons

| pin-filled | interface | pin filled in | A pin pointing downwards filled in |

| pin-stroke | interface | pin outlined | A pin pointing downwards outlined |

The icon(s) per this request, has the new art been completed?

Yes, art has been added to the Figma docs

Attach exported SVG files to this issue

interface:pin-filled.svg.zip
interface:pin-stroke.svg.zip
@Julieta253 Julieta253 added icons not-reviewed Issue has not been reviewed by Auro team members labels Mar 11, 2024
@blackfalcon blackfalcon changed the title [new pin icons] new pin icons Mar 11, 2024
@blackfalcon
Copy link
Member

@Julieta253 Please see issue #210

With direction from @EricGalindo1 we implemented a series of updates, some of those updates are related to how icons are described.

I am curious what the design team is considering the standard. Your icon descriptions are describing the action the icon represents and the updates we made, as will see, are more descriptive of the appearance of the icon.

Please reach out if you have any questions.

@Julieta253
Copy link
Author

Hello @blackfalcon I have edited the descriptions to match the new style. Let me know if there are any other issues to fix, thank you!

@Patrick-Daly-AA Patrick-Daly-AA removed their assignment Mar 15, 2024
@Patrick-Daly-AA Patrick-Daly-AA removed the not-reviewed Issue has not been reviewed by Auro team members label Mar 15, 2024
blackfalcon added a commit that referenced this issue Mar 19, 2024
@blackfalcon
feat: update pin SVG with new versions #240
d05ef6c 
This commit updates to SVGs in the interface category.

Changes to be committed:
modified:   src/data/icons.json
modified:   src/icons/pin-filled.svg
modified:   src/icons/pin-stroke.svg
@blackfalcon blackfalcon mentioned this issue Mar 19, 2024
Merged
6 tasks
@blackfalcon blackfalcon linked a pull request Mar 19, 2024 that will close this issue
Add new mug and update pin icons #242
Merged
6 tasks
blackfalcon added a commit that referenced this issue Mar 19, 2024
@blackfalcon
feat: update pin SVG with new versions #240
f3dafbb 
This commit updates two SVGs in the interface category.

Changes to be committed:
modified:   src/data/icons.json
modified:   src/icons/pin-filled.svg
modified:   src/icons/pin-stroke.svg
jordanjones243 pushed a commit that referenced this issue Mar 20, 2024
@blackfalcon @jordanjones243
feat: update pin SVG with new versions #240
9f83a30 
This commit updates two SVGs in the interface category.

Changes to be committed:
modified:   src/data/icons.json
modified:   src/icons/pin-filled.svg
modified:   src/icons/pin-stroke.svg
blackfalcon pushed a commit that referenced this issue Mar 20, 2024
@semantic-release-bot
chore(release): 4.39.0 [skip ci]
f5c400f 
# [4.39.0](v4.38.0...v4.39.0) (2024-03-20)

### Features

* add new mug icons to repo [#241](#241) ([4215529](4215529))
* update pin SVG with new versions [#240](#240) ([9f83a30](9f83a30))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@blackfalcon blackfalcon

@michelle-alaskaair michelle-alaskaair

Labels
icons
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add new mug and update pin icons AlaskaAirlines/Icons
4 participants
@blackfalcon @Julieta253 @Patrick-Daly-AA @michelle-alaskaair