Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auro-form: Update component registration logic #13

Closed
sun-mota opened this issue Oct 22, 2024 · 1 comment
Closed

auro-form: Update component registration logic #13

sun-mota opened this issue Oct 22, 2024 · 1 comment
Assignees

Comments

@sun-mota
Copy link
Contributor

Please verify the version of auro-form you have installed

No response

Please describe the bug

Default import of index.js should register the default custom element only.

import of the component class should not register the custom element at all.

Remove all registration of custom-${component name} from the JS and only register as part of ./demo/index.js

Reproducing the error

None

Expected behavior

No response

What browsers are you seeing the problem on?

No response

Additional context

No response

Exit criteria

No response

@sun-mota sun-mota added auro-form not-reviewed Issue has not been reviewed by Auro team members Type: Bug Bug or Bug fixes labels Oct 22, 2024
@sun-mota sun-mota self-assigned this Oct 22, 2024
sun-mota added a commit that referenced this issue Oct 23, 2024
- `AuroForm.register` is to easily register the element without extra importing
- `import '@aurodesignsystem/auro-form'` will still register this element to `<auro-form>`
- `import { AuroForm } from '../src/auro-form'` wont register this element until `AuroForm.register` gets called
@jason-capsule42 jason-capsule42 removed not-reviewed Issue has not been reviewed by Auro team members Type: Bug Bug or Bug fixes labels Oct 27, 2024
@sun-mota sun-mota linked a pull request Nov 5, 2024 that will close this issue
@sun-mota sun-mota closed this as completed Nov 5, 2024
@sun-mota
Copy link
Contributor Author

sun-mota commented Nov 5, 2024

will be handled in #21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants