Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SELECT: label doesn't move up when value is selected #36

Open
leeejune opened this issue May 7, 2022 · 2 comments · May be fixed by #134
Open

SELECT: label doesn't move up when value is selected #36

leeejune opened this issue May 7, 2022 · 2 comments · May be fixed by #134
Assignees
@sun-mota

Comments

@leeejune
Copy link

leeejune commented May 7, 2022

Is your feature request related to a problem? Please describe.

The current dropdown behavior is not 1:1 to the blueprint. The label should not always be shown unless there is a label AND a placeholder. Refer to the screenshot and blueprint below.
Screen Shot 2022-05-06 at 5 02 55 PM

https://www.figma.com/file/3TQhiKjQqQOKYqaqcO1zj2/Dropdown?node-id=906%3A1298

Describe the solution you'd like

When there is a label but no placeholder, the label should move up when there is a value selected (default state has label text in the middle and in the filled state the label moves up while the selected value takes up the middle space).
@leeejune leeejune added not-reviewed Issue has not been reviewed by Auro team members Type: Feature New Feature labels May 7, 2022
@leeejune leeejune changed the title auro-dropdown: label moves up when filled out auro-dropdown: label doesn't move up when value is selected May 7, 2022
@leeejune leeejune mentioned this issue May 7, 2022
Closed
@braven112 braven112 removed the not-reviewed Issue has not been reviewed by Auro team members label May 12, 2022
@blackfalcon blackfalcon added Type: Bug Bug or Bug fixes and removed Type: Feature New Feature labels Jun 20, 2022
@leeejune leeejune mentioned this issue Aug 1, 2022
Closed
@blackfalcon blackfalcon added the not-reviewed Issue has not been reviewed by Auro team members label Jan 21, 2023
@Patrick-Daly-AA
Copy link

After discussion, current solution to this is to include an example on the Doc site for the left column of the picture in the original issue.

@Patrick-Daly-AA
Copy link

Issue should be addressed by implementation of AlaskaAirlines/auro-select#84

@jason-capsule42 jason-capsule42 removed not-reviewed Issue has not been reviewed by Auro team members Type: Bug Bug or Bug fixes labels Oct 3, 2024
@jordanjones243 jordanjones243 transferred this issue from AlaskaAirlines/auro-dropdown Nov 8, 2024
@jason-capsule42 jason-capsule42 changed the title auro-dropdown: label doesn't move up when value is selected DROPDOWN: label doesn't move up when value is selected Dec 3, 2024
@sun-mota sun-mota changed the title DROPDOWN: label doesn't move up when value is selected SELECT: label doesn't move up when value is selected Dec 17, 2024
sun-mota added a commit that referenced this issue Dec 19, 2024
@sun-mota
refactor: set dropdown.label with the default font-size when placehol…
6b43eb1 
…der has no text to render #36
sun-mota added a commit that referenced this issue Dec 19, 2024
@sun-mota
refactor: set dropdown.label with the default font-size when placehol…
7d8a06d 
…der has no text to render #36
@sun-mota sun-mota linked a pull request Dec 19, 2024 that will close this issue
dropdown/select: when there is no placeholder, label will have default font-size #134
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sun-mota sun-mota

Labels
None yet
Projects
None yet
Milestone
No milestone
7 participants
@blackfalcon @braven112 @sun-mota @jason-capsule42 @jordanjones243 @leeejune @Patrick-Daly-AA