Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INPUT: Add functionality to only make the "x" icon display when component has focused or is being hovered #158

Closed
jordanjones243 opened this issue Dec 30, 2024 · 1 comment · Fixed by #122
Assignees
Labels

Comments

@jordanjones243
Copy link
Contributor

General Support Request

Currently the "x" icon displays whenever an input has a value in it. We want to change this to only display when the input has a value AND it either has focus or is being hovered.

Possible Solution

Add some css to make "x" display on hover (the icon already displays when it has focus"

Additional context

Issue stems from usage of combobox on this site:
https://www.alaskaair.com/search/?lid=nav:book-flights&int=AS_NAV_Book_Flights_-prodID:ShoppingBooking

Exit criteria

"x" icon only displays when input has a value and it has focus or is being hovered over.

@jordanjones243 jordanjones243 added auro-form not-reviewed Issue has not been reviewed by Auro team members Type: Feature New Feature labels Dec 30, 2024
@Patrick-Daly-AA Patrick-Daly-AA removed their assignment Dec 31, 2024
@Patrick-Daly-AA Patrick-Daly-AA removed the not-reviewed Issue has not been reviewed by Auro team members label Dec 31, 2024
@jordanjones243 jordanjones243 self-assigned this Dec 31, 2024
@jordanjones243 jordanjones243 linked a pull request Dec 31, 2024 that will close this issue
jason-capsule42 pushed a commit that referenced this issue Dec 31, 2024
# [1.6.0-beta.11](v1.6.0-beta.10...v1.6.0-beta.11) (2024-12-31)

### Bug Fixes

* eslint rules, naming errors ([ca27f4c](ca27f4c))
* remove any instances of type=numeric [#120](#120) ([7ba5463](7ba5463))
* update layout to match figma [#79](#79) ([58dffaf](58dffaf))
* validate each individual attribute [#119](#119) ([67bbb44](67bbb44))

### Features

* add reset function to validation script [#135](#135) ([9119e06](9119e06))
* add reset functionality to checkbox ([292845e](292845e))
* add reset functionality to combobox ([6e8ea9b](6e8ea9b))
* add reset functionality to datepicker ([b2b6a10](b2b6a10))
* add reset functionality to input ([2027706](2027706))
* add reset functionality to radio ([5b961dc](5b961dc))
* add reset functionality to select ([2f07d97](2f07d97))

### Performance Improvements

* add min.js files ([503802e](503802e))
* hide input arrows for type=number ([9a56754](9a56754))
* improve documentation around type=number ([76718a9](76718a9))
* reflect value attribute onto input component ([ea3c731](ea3c731))
* remove all references of isValid attribute ([b66d47e](b66d47e))
* remove reflected value attribute from all components ([706f409](706f409))
* show clear icon on hover or focus [#158](#158) ([3c48343](3c48343))
@jordanjones243
Copy link
Contributor Author

Ticket has been completed and merged into Beta.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants