Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auro Library incorrectly installed in devDependencies #7

Closed
chrisfalaska opened this issue Oct 7, 2024 · 1 comment
Closed

Auro Library incorrectly installed in devDependencies #7

chrisfalaska opened this issue Oct 7, 2024 · 1 comment
Assignees
@chrisfalaska
Labels
auro-form

Comments

@chrisfalaska
Copy link
Contributor

Please verify the version of auro-form you have installed

0.0.0

Please describe the bug

  1. Open package.json
  2. Note that "@aurodesignsystem/auro-library": "^2.8.0", is listed inside devDependencies

Reproducing the error

None

Expected behavior

To avoid issues when installing into projects, Auro Library needs to be listed as part of dependencies.

What browsers are you seeing the problem on?

No response

Additional context

First reported in AlaskaAirlines/WC-Generator#573

Exit criteria

  1. Auro Library listed in dependencies
  2. build runs correctly
  3. tests pass
@chrisfalaska chrisfalaska added auro-form not-reviewed Issue has not been reviewed by Auro team members Type: Bug Bug or Bug fixes labels Oct 7, 2024
@chrisfalaska chrisfalaska self-assigned this Oct 7, 2024
chrisfalaska pushed a commit that referenced this issue Oct 7, 2024
fix: moves auro library to dependencies in package.json #7
48238fb
chrisfalaska pushed a commit that referenced this issue Oct 7, 2024
fix: moves auro library to dependencies in package.json #7
8e96456
@chrisfalaska chrisfalaska mentioned this issue Oct 7, 2024
Closed
3 tasks
@chrisfalaska chrisfalaska linked a pull request Oct 7, 2024 that will close this issue
fix: moves auro library to dependencies in package.json #7 #8
Closed
3 tasks
@chrisfalaska chrisfalaska removed not-reviewed Issue has not been reviewed by Auro team members Type: Bug Bug or Bug fixes labels Oct 7, 2024
@Patrick-Daly-AA Patrick-Daly-AA removed their assignment Oct 28, 2024
@jason-capsule42
Copy link
Member

This work was already completed as part of another body of work.

@jason-capsule42 jason-capsule42 closed this as not planned Won't fix, can't repro, duplicate, stale Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chrisfalaska chrisfalaska

Labels
auro-form
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: moves auro library to dependencies in package.json #7 AlaskaAirlines/auro-formkit
3 participants
@jason-capsule42 @Patrick-Daly-AA @chrisfalaska