Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Icons in hyperlinks are not audible accessible #134

Closed
blackfalcon opened this issue Aug 25, 2022 · 2 comments
Closed

Icons in hyperlinks are not audible accessible #134

blackfalcon opened this issue Aug 25, 2022 · 2 comments
Assignees
@blackfalcon
Labels
auro-hyperlink released Completed work has been released Type: Bug Bug or Bug fixes
Milestone
a11y screen reade...

Comments

@blackfalcon
Copy link
Member

blackfalcon commented Aug 25, 2022 •
edited
Loading

Describe the bug

Icons in the hyperlink are not being read aloud by screen readers.

To Reproduce

Steps to reproduce the behavior:

  1. Go to https://auro.alaskaair.com/components/auro/hyperlink
  2. Turn on screen reader
  3. See error

Expected behavior

Icons should read aloud the title text fo the SVG icons to a screen reader.

Additional context

Exit criteria

There should be no additional work required for auro-hyperlink. The work itself is on the auro icons library and the removal of aria-hidden by default.

Once this element is updated with a reference to the updated icons lib, the readability of the icon's alt info by screen readers should be addressed.
@blackfalcon blackfalcon added Type: Bug Bug or Bug fixes Status: Work In Progress Issue or Pull Request work is in Progress auro-hyperlink labels Aug 25, 2022
@blackfalcon blackfalcon self-assigned this Aug 25, 2022
@blackfalcon blackfalcon added not-reviewed Issue has not been reviewed by Auro team members and removed Status: Work In Progress Issue or Pull Request work is in Progress labels Aug 25, 2022
@blackfalcon blackfalcon removed their assignment Aug 25, 2022
@blackfalcon blackfalcon mentioned this issue Aug 25, 2022
Open
@blackfalcon blackfalcon self-assigned this Sep 22, 2022
@blackfalcon blackfalcon removed their assignment Nov 23, 2022
@blackfalcon blackfalcon added this to the a11y screen reader desc milestone Nov 30, 2022
@blackfalcon blackfalcon self-assigned this Nov 30, 2022
@blackfalcon blackfalcon removed the not-reviewed Issue has not been reviewed by Auro team members label Dec 7, 2022
@blackfalcon
Copy link
Member Author

Once the following PR is released, this repo will need to be updated to link the updated dependency version.

blackfalcon added a commit that referenced this issue Dec 20, 2022
@blackfalcon
fix(icons): update peer dependency of auro icons #134
f843b74 
Changes to be committed:
modified:   package-lock.json
modified:   package.json
modified:   packageScripts/postinstall.js
blackfalcon pushed a commit that referenced this issue Dec 20, 2022
@semantic-release-bot
chore(release): 3.2.1 [skip ci]
fad0bf1 
## [3.2.1](v3.2.0...v3.2.1) (2022-12-20)

### Bug Fixes

* **icons:** update peer dependency of auro icons [#134](#134) ([f843b74](f843b74))
@blackfalcon
Copy link
Member Author

Released

@blackfalcon blackfalcon added the released Completed work has been released label Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@blackfalcon blackfalcon

Labels
auro-hyperlink released Completed work has been released Type: Bug Bug or Bug fixes
Projects
None yet
Milestone
a11y screen reader desc
Development

No branches or pull requests
1 participant
@blackfalcon