Auro-icon: Update component registration logic #144
Assignees
Labels
Comments
sun-mota
added
Type: Bug
6 tasks
6 tasks
Closed
25 tasks
sun-mota
added a commit
that referenced
this issue
Oct 21, 2024
AuroIcon.register is to easily register the element without extra importing
`import '@aurodesignsystem/auro-icon'` will still register this element to `<auro-icon>`
`import { AuroIcon } from '../src/auro-icon.js` wont register this element until `AuroIcon.register` gets called
Similarly, `AuroAlaska` now needs to be registered using `AuroAlaska.register` before you can use `<auro-alaska>,` if you're importing `auro-alaska.js`.
To skip the registration step, you can simply import `@aurodesignsystem/auro-icon`.
sun-mota
added a commit
that referenced
this issue
Oct 24, 2024
…ine <auro-icon> as a customElement #144 - Update dependency versions - `AuroIcon.register` is to easily register the element without extra importing - `import '@aurodesignsystem/auro-icon'` will still register this element to `<auro-icon>` - `import { AuroIcon } from '../src/auro-icon.js` wont register this element until `AuroIcon.register` gets called - Similarly, `AuroAlaska` now needs to be registered using `AuroAlaska.register` before you can use `<auro-alaska>,` if you're importing `auro-alaska.js`. To skip the registration step, you can simply import `@aurodesignsystem/auro-icon`.
jason-capsule42
removed
Type: Bug
jordanjones243
pushed a commit
that referenced
this issue
Oct 28, 2024
…con> as a customElement #144 BREAKING CHANGE: `auro-alaska` must be registered to use the `src/auro-alaska.js` import. - Update dependency versions - `AuroIcon.register` is to easily register the element without extra importing - `import '@aurodesignsystem/auro-icon'` will still register this element to `<auro-icon>` - `import { AuroIcon } from '../src/auro-icon.js` wont register this element until `AuroIcon.register` gets called - Similarly, `AuroAlaska` now needs to be registered using `AuroAlaska.register` before you can use `<auro-alaska>,` if you're importing `auro-alaska.js`. To skip the registration step, you can simply import `@aurodesignsystem/auro-icon`.
jordanjones243
pushed a commit
that referenced
this issue
Oct 28, 2024
…con> as a customElement #144 BREAKING CHANGE: `auro-alaska` must be registered to use the `src/auro-alaska.js` import. - Update dependency versions - `AuroIcon.register` is to easily register the element without extra importing - `import '@aurodesignsystem/auro-icon'` will still register this element to `<auro-icon>` - `import { AuroIcon } from '../src/auro-icon.js` wont register this element until `AuroIcon.register` gets called - Similarly, `AuroAlaska` now needs to be registered using `AuroAlaska.register` before you can use `<auro-alaska>,` if you're importing `auro-alaska.js`. To skip the registration step, you can simply import `@aurodesignsystem/auro-icon`.
blackfalcon
pushed a commit
that referenced
this issue
Oct 28, 2024
# [6.0.0](v5.0.2...v6.0.0) (2024-10-28) ### Bug Fixes * change how we support custom size [#147](#147) ([5cbb375](5cbb375)) ### Features * add tag name as attribute when custom registered ([669997a](669997a)) * **api:** importing ./src/auro-icon.js will no longer define <auro-icon> as a customElement [#144](#144) ([353d5c3](353d5c3)) ### Performance Improvements * update deps ([2d91c53](2d91c53)) * update sweep npm script ([4f2a171](4f2a171)) ### BREAKING CHANGES * the old customSize attribute is no longer supported. See new documentation on API page under Theme Support. * **api:** `auro-alaska` must be registered to use the `src/auro-alaska.js` import. - Update dependency versions - `AuroIcon.register` is to easily register the element without extra importing - `import '@aurodesignsystem/auro-icon'` will still register this element to `<auro-icon>` - `import { AuroIcon } from '../src/auro-icon.js` wont register this element until `AuroIcon.register` gets called - Similarly, `AuroAlaska` now needs to be registered using `AuroAlaska.register` before you can use `<auro-alaska>,` if you're importing `auro-alaska.js`. To skip the registration step, you can simply import `@aurodesignsystem/auro-icon`.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Please verify the version of auro-icon you have installed
No response
Please describe the bug
Default import of index.js should register the default custom element only.
import of the component class should not register the custom element at all.
Remove all registration of
custom-${component name}from the JS and only register as part of ./demo/index.jsReproducing the error on the docsite
None
Expected behavior
No response
What browsers are you seeing the problem on?
No response
Additional context
No response
Exit criteria
No response
The text was updated successfully, but these errors were encountered: