Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

auro-icon: Theming Support #96

Closed
braven112 opened this issue Oct 20, 2023 · 1 comment
Closed

auro-icon: Theming Support #96

braven112 opened this issue Oct 20, 2023 · 1 comment
Assignees
@fajar-apri-alaska @irma-kurnia-alaska
Labels
auro-icon not-reviewed Issue has not been reviewed by Auro team members Type: Feature New Feature

Comments

@braven112
Copy link
Member

braven112 commented Oct 20, 2023 •
edited
Loading

Is your feature request related to a problem? Please describe.

This is regarding theming updates that need to happen to nearly all auro components

Describe the solution you'd like

  1. All tokens with the prefix --auro need to be renamed to --ds so they work with the new WCSS v5 update.
  2. The WCSS package needs to be updated to ^5.0.0 and the import paths in the component *.scss files need to be updated as well

Describe alternatives you've considered

None

Additional context

Reference this auro-button pr AlaskaAirlines/auro-button#231
and this auro-hyperlink pr AlaskaAirlines/auro-hyperlink#185

Exit criteria

All tokens referencing --auro have been updated.
Validate the changes after this work item is also complete
@braven112 braven112 added Type: Feature New Feature auro-icon not-reviewed Issue has not been reviewed by Auro team members labels Oct 20, 2023
@braven112 braven112 changed the title auro-icon: [feature summary] auro-icon: Theming Support Oct 20, 2023
@irma-kurnia-phtn
Copy link
Contributor

Hi @braven112,

Sorry, this issue it's the same as the #94 ?
this issue should be fix by Dale Sande, at the PR #95.

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fajar-apri-alaska fajar-apri-alaska

@irma-kurnia-alaska irma-kurnia-alaska

Labels
auro-icon not-reviewed Issue has not been reviewed by Auro team members Type: Feature New Feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@blackfalcon @braven112 @fajar-apri-alaska @irma-kurnia-alaska @Patrick-Daly-AA @irma-kurnia-phtn