Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--ds-size-300 design token gets overwritten with "100%" #97

Closed
arrenleung opened this issue Nov 15, 2023 · 4 comments
Closed

--ds-size-300 design token gets overwritten with "100%" #97

arrenleung opened this issue Nov 15, 2023 · 4 comments
Assignees
Labels
Abandoned The author of this issue or Pull Request is not responding auro-icon not-reviewed Issue has not been reviewed by Auro team members Type: Bug Bug or Bug fixes

Comments

@arrenleung
Copy link

Please verify the version of auro-icon you have installed

4.1.0

Please describe the bug

  1. Create an auro-icon instance
  2. Assign a width and/or height of "var(--ds-size-300)"
  3. In CSS dev tools, see that the --ds-size-300 token is being overwritten with "100%" instead of 1.5rem

Reproducing the error on the docsite

This issue is reproducible on the Auro docsite

Expected behavior

When applying a width/height of var(--ds-size-300) to an auro-icon component, the design token returns 1.5rem.

What browsers are you seeing the problem on?

Chrome, Safari

Additional context

No response

Exit criteria

When applying a width/height of var(--ds-size-300) to an auro-icon component, the design token returns 1.5rem.

@arrenleung arrenleung added auro-icon not-reviewed Issue has not been reviewed by Auro team members Type: Bug Bug or Bug fixes labels Nov 15, 2023
@blackfalcon
Copy link
Member

@arrenleung can you please supply code and/or screenshots of how you are witnessing this happening?

@jordanjones243
Copy link
Contributor

@arrenleung I also just ran into this issue working on something else. The current workaround is to do a calculation to add up to --ds-size-300. For example, you would do calc(var(--ds-size-200) + var(--ds-size-100))

@blackfalcon
Copy link
Member

@jordanjones243 correct me if I am wrong, but is this the issue where the customSize attribute is being used?

@arrenleung if I understand this issue correctly there was an issue where the appropriate tokens were not being referenced within the scope of the icon element causing this issue to appear when also using the customSize attribute.

Can you please confirm if this IS or IS NOT still an issue in your UIs?

@blackfalcon
Copy link
Member

If there is no response to this issue from the author within 30 days, this issue will be considered abandoned and it will be closed.

@blackfalcon blackfalcon added the Abandoned The author of this issue or Pull Request is not responding label Apr 12, 2024
@blackfalcon blackfalcon closed this as not planned Won't fix, can't repro, duplicate, stale Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Abandoned The author of this issue or Pull Request is not responding auro-icon not-reviewed Issue has not been reviewed by Auro team members Type: Bug Bug or Bug fixes
Projects
None yet
Development

No branches or pull requests

4 participants