Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with syntax highlighting SVG #13

Closed
printfn opened this issue Feb 25, 2024 · 2 comments
Closed

Issue with syntax highlighting SVG #13

printfn opened this issue Feb 25, 2024 · 2 comments

Comments

@printfn
Copy link

printfn commented Feb 25, 2024

It looks like the SVG grammar in this repository is used on GitHub, right? I noticed that this SVG file isn’t being syntax-highlighted correctly:

<svg xmlns="http://www.w3.org/2000/svg" width="500" height="500">
    <defs>
        <linearGradient id="backgroundGradient" x1="0%" y1="0%" x2="0%" y2="100%">
            <stop offset="0%" style="stop-color:#ffbc6b;stop-opacity:1" />
            <stop offset="100%" style="stop-color:#ff8100;stop-opacity:1" />
        </linearGradient>
    </defs>
</svg>

Original file: https://github.com/printfn/fend/blob/567bb4c8bf0cf2aeb459c2c7cd463294f2faf007/icon/icon.svg

@Alhadis
Copy link
Owner

Alhadis commented Feb 27, 2024

See github-linguist/linguist#6668. The mangled SVG highlighting is actually the fault of a larger issue with GitHub's syntax highlighting engine. The SVG grammar itself is well-formed and was working as intended until the aforementioned regression.

Unfortunately, there's nothing I (or anybody who isn't GitHub staff) can do to expedite a solution. I recommend monitoring github-linguist/linguist#6668 for updates until this annoying bug has finally been squashed.

@Alhadis Alhadis closed this as completed Feb 27, 2024
@Alhadis
Copy link
Owner

Alhadis commented Mar 13, 2024

@printfn Just a heads-up that GitHub fixed the aforementioned issue this morning. Your SVG code should now be correctly-highlighted again. 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants