Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip pre-commit hooks in lint-fix workflow #5164

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

neubig
Copy link
Contributor

@neubig neubig commented Nov 21, 2024

Modified the lint-fix workflow to skip pre-commit hooks when committing changes. This ensures that linting fixes can be pushed even if other pre-commit checks would fail.

@neubig neubig requested a review from mamoodi November 21, 2024 03:00
git add -A
git commit -m "🤖 Auto-fix linting issues"
SKIP_PRE_COMMIT=1 git add -A
SKIP_PRE_COMMIT=1 git commit -m "🤖 Auto-fix linting issues"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@openhands-agent
I'm looking if this variable, SKIP_PRE_COMMIT, exists. It doesn't seem so. 😅 Verify and fix this.

@enyst enyst added the fix-me Attempt to fix this issue with OpenHands label Nov 21, 2024
@enyst enyst added fix-me Attempt to fix this issue with OpenHands and removed fix-me Attempt to fix this issue with OpenHands labels Nov 21, 2024
@enyst
Copy link
Collaborator

enyst commented Nov 21, 2024

The macro/label run fails from the start with LLM_MODEL not found 🤔. I'm not sure why.

@neubig
Copy link
Contributor Author

neubig commented Nov 21, 2024

Very weird, this worked on my fork: neubig#1

I'll investigate.

@enyst
Copy link
Collaborator

enyst commented Nov 21, 2024

Thank you, please let me know how I can help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix-me Attempt to fix this issue with OpenHands lint-fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants