Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Once silo/overlink extract is added, add ability for silo/overlink options to flow through #1376

Open
JustinPrivitera opened this issue Aug 29, 2024 · 2 comments
Assignees

Comments

@JustinPrivitera
Copy link
Member

https://github.com/LLNL/conduit/blob/fa0f8d3738b0c4cef95a0d05003f3b80aa381f23/src/libs/relay/conduit_relay_io_silo.cpp#L5690

Some of these will be covered already - overlink file style, num files. But others would be nice to support: silo_type, root_file_ext, etc.

@JustinPrivitera JustinPrivitera self-assigned this Aug 29, 2024
@JustinPrivitera
Copy link
Member Author

I think, once we get this implemented, we should remove all the MPI logic I have written to check that only a single topology is selected. We can just use the ovl_topo_name argument instead. Conduit will warn users that they are attempting to write multiple with Overlink and it will tell them which choice it made. They can use the argument to control this instead of enforcing it in Ascent.

@JustinPrivitera
Copy link
Member Author

silo/overlink extract will be added in #1377

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant