Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build_ascent_hip_frontier.sh fails when compiling vtkm #1415

Open
mlohry opened this issue Nov 5, 2024 · 3 comments
Open

build_ascent_hip_frontier.sh fails when compiling vtkm #1415

mlohry opened this issue Nov 5, 2024 · 3 comments

Comments

@mlohry
Copy link
Contributor

mlohry commented Nov 5, 2024

Using build_ascent_hip_frontier.sh on frontier, it looks like some part of vtkm isn't properly including mpi:

[...]/ascent/scripts/build_ascent/source/vtk-m-v2.1.0/vtkm/filter/flow/internal/BoundsMap.h:25:10: fatal error: 'mpi.h' file not found

If I force the include with export CPATH=/opt/cray/pe/mpich/8.1.28/ofi/crayclang/17.0/include/ it passes this point.

@cyrush
Copy link
Member

cyrush commented Nov 6, 2024

When compiling with the cray compilers, they know where MPI exists.

However, in VTK-m, the compile drops to only use amdclang++ to compile device code and it does not know about implicit mpi paths.

The fix is to add the MPI include path to general includes, we can add this to the frontier script.

@cyrush
Copy link
Member

cyrush commented Nov 6, 2024

@mlohry

Where you trying the latest script, we do have some logic to address this:

export CXXFLAGS="${CRAY_ROCM_INCLUDE_OPTS} -I/opt/cray/pe/mpich/8.1.28/ofi/crayclang/17.0/include/ -Wno-pass-failed"

@mlohry
Copy link
Contributor Author

mlohry commented Nov 7, 2024

@cyrush yes I used the latest and I see that line there, odd that it didn't work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants