Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Report: Missing headers in camp and mfem building over Ascent tags/v0.9.0-0.9.2 #1416

Open
timohyva opened this issue Nov 6, 2024 · 4 comments

Comments

@timohyva
Copy link

timohyva commented Nov 6, 2024

I am on a Cray SUSE 15 enterprise cluster with crayPE/24.03. I was using build _ascent.sh to build dependencies with mpich and gcc/13.2.

It appears that

  • camp-2022.10.1/include/camp/resource/host.hpp miss #include <cstdlib>
  • camp-2022.10.1/include/camp/resource.hpp miss #include <stdexcept>
  • mfem-4.5.2/general/hash.hpp and mfem-4.5.2/general/mem_manager.cpp miss #include <cstdint>

The error messages typically are

camp-2022.10.1/include/camp/resource/host.hpp:65:71: error: ‘free’ was not declared in this scope
   65 |       void deallocate(void *p, MemoryAccess = MemoryAccess::Device) { free(p); }
...
camp-2022.10.1/include/camp/resource/host.hpp:57:27: error: ‘malloc’ was not declared in this scope, and no declarations were found by argument-dependent lookup at the point of instantiation
   57 |         return (T *)malloc(sizeof(T) * n);
...
mfem-4.5.2/general/hash.hpp:1001:39: error: ‘uint64_t’ was not declared in this scope
 1001 |       auto k = reinterpret_cast<const uint64_t &>(*begin);
...
mfem-4.5.2/general/mem_manager.cpp:268:10: error: ‘uintptr_t’ does not name a type
  268 |    const uintptr_t addr = (uintptr_t) ptr;
...

These missing headers appear over Ascent/v0.9.0-0.9.2 building scripts. After manually access these source files and adding missing headers, camp and mfem can been built successfully, so does Ascent.

I have red this closed issue #1259, it looks just same problem as I get. I wonder does it solved also for tags? I checkout tags/v0.9.x to get release. Is this good practice?

@cyrush
Copy link
Member

cyrush commented Nov 6, 2024

@timohyva #1259 resolved an issue with camp, to resolve a few gcc mfem issues I think we need to use the mfem 4.7 release.

That said Ascent 0.9.3 is using MFEM 4.6.x. Have you tried 0.9.3?

We do not resolve build issues for older releases, we fix build patterns and scripts and create new releases.

@timohyva
Copy link
Author

timohyva commented Nov 6, 2024

I don't build 0.9.3 yet, may be I should find time to try it out and see what it turns out.

Or could I just modify version number of mfem to 4.7 in build_ascent.sh, will it induces problem related to old/new APIs between dependencies and Ascent?

@cyrush
Copy link
Member

cyrush commented Nov 6, 2024

I believe that mfem 4.7 will work with Ascent 0.9.3, based on: #1393

In general: due to libs making API changes - mixing and matching TPLs may cause issues.
This is why we share what versions we are using for each release:

https://github.com/Alpine-DAV/ascent/blob/develop/CHANGELOG.md

@timohyva
Copy link
Author

timohyva commented Nov 7, 2024

I didn't know Ascent devs provide changlog, looks like it provides clear track of dependencies' version.

If I understand right, the versions which aren't mentioned under Preferred dependency versions for Ascent@... are same as they are in earlier version of Ascent, right? I find it takes quite a bit time to trace down exactly which version of dependency one suppose to use.

I will give feedback after I try out v0.9.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants