Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#11866, #18115 제출합니다.
bsa0322
reviewed
Sep 15, 2022
Comment on lines
+20
to
+36
| for (int i = 1; i <= n; i++) { | ||
| int store; | ||
| switch (input[n - i]) { | ||
| case 1: | ||
| arr.push_back(i); | ||
| break; | ||
| case 2: | ||
| store = arr.back(); | ||
| arr.pop_back(); | ||
| arr.push_back(i); | ||
| arr.push_back(store); | ||
| break; | ||
| case 3: | ||
| arr.push_front(i); | ||
| break; | ||
| } | ||
| } |
There was a problem hiding this comment.
p2. 해당 부분은 문제의 핵심 연산이니 함수화를 하면 가독성을 더 높일 수 있을 것 같습니다! 특히, 코딩테스트에선 solution 타입이 대부분으로, main함수가 제공되지 않고 solution함수만 제공되어 정답을 리턴하는 형태이니 지금부터 함수화에 익숙해지시면 좋을 것 같아요! 🔥
Comment on lines
+38
to
+40
| for (int i = 0; i < n; i++) { | ||
| cout << arr[n - i - 1] << ' '; | ||
| } |
There was a problem hiding this comment.
p3. deque의 back()연산을 활용하면 더욱 간편하게 출력을 할 수 있을 것 같아요~! 👍
jk0527
reviewed
Sep 15, 2022
|
|
||
| cout << '<'; | ||
|
|
||
| while (n--) { |
There was a problem hiding this comment.
연산을 하는 부분은 함수화해도 좋을 것 같아요. 그리고 출력 하는 부분이 좀 흩어져 있네요..! vector에 저장한 후에 출력하면 좀 더 코드가 깔끔해질 것 같아요!! 함수에서 vector에 원소를 순서대로 저장하고
vector를 main으로 리턴해서 한 번에 출력하면 어떨까요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
내용&질문
제출합니다!
<기존 제출>
11866, 18115