-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate OpenSSL 3.x #89
Conversation
.github/workflows/MSBuild.yml
Outdated
dotnet-version: '3.1.x' | ||
env: | ||
DOTNET_MULTILEVEL_LOOKUP: false | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if we still need this old version. I think 6.0 is the oldest still supported version. We should probable enable 8.0 for the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated to net6.0 for now
.github/workflows/MSBuild.yml
Outdated
@@ -12,7 +13,7 @@ env: | |||
|
|||
jobs: | |||
build: | |||
runs-on: windows-latest | |||
runs-on: windows-2022 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would assume latest is 2022? Or is that still 2019?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes windows-latest is currently windows-2022. To ensure there are no implicit changes of the runner "windows-2022" might be the better option
src/SharpSvn/SharpSvnStrings.h
Outdated
// -Klasse über ein Tool wie ResGen oder Visual Studio automatisch generiert. | ||
// Um einen Member hinzuzufügen oder zu entfernen, bearbeiten Sie die .ResX-Datei und führen dann ResGen | ||
// mit der /str-Option erneut aus, oder Sie erstellen Ihr VS-Projekt neu. | ||
[System::CodeDom::Compiler::GeneratedCodeAttribute(L"System.Resources.Tools.StronglyTypedResourceBuilder", L"4.0.0.0"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice... generated the German texts as default ;-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverted changes to the file and commited old version
Feel free to update to .Net 6. Talked with Markus. Feel free to get this through... I'll get things released through NuGet when done on master. |
@pde-cds check your mail. Should be invite to project member, so the tests should work directly, etc. |
…s/SharpSvn into investigation/openssl-3.x # Conflicts: # .github/workflows/MSBuildV2.yml
This reverts commit 6accffa.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Feel free to merge when done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed the changes
Created a buildable state including OpenSSL 3.0.12 and Apache Subversion 1.14.3.
Currently only x64,x86 and ARM64 build sucessfully including Unittests (Some Unittest had to be deactivated because they relied on ctf.open.collab.net.)
.Net Core 3.1 builds are also successful but UnitTests fail
-> Maybe update to .Net 6.0 or higher?.NET 6.0 update seems to be more difficult as expected -> Staying on .NetCore3.1Necessary steps
Tests for .Net Core 3.1 do run but only on x64 because of DotNet test runs fail for a x86 projects - Microsoft.WindowsDesktop.App (net core 6) is missing on windows-latest runner, actions/setup-dotnet#485Updated SharpSvn.Tests to net6.0 (build artifacts stay on .netcore3.1