Skip to content
This repository has been archived by the owner on Sep 1, 2021. It is now read-only.

Roll pulling service may miss rolls during restart #109

Open
AndreMiras opened this issue Sep 16, 2018 · 0 comments
Open

Roll pulling service may miss rolls during restart #109

AndreMiras opened this issue Sep 16, 2018 · 0 comments
Labels
enhancement New feature or request

Comments

@AndreMiras
Copy link
Owner

When the app shuts down, the service is being killed and restarted, see 55348e7. However it takes some time between the service down and back up (approx 10-30 seconds on Honor 5C) and during this time we may miss some notifications.
This is also happening because of the way we're deciding upon if a roll is new or not. Rolls are kept in service RAM memory and a diff is created between two pulls. When the service restarts the state is lost.
We could save that state on disk, however if the app doesn't run for a while, but the player still rolled with this address (not in the app), next time he opens, it will show lot of notifications.
We could also still save on disk, but ignore rolls that are older than a given time period so we don't notify on them.

@AndreMiras AndreMiras added the enhancement New feature or request label Sep 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant