Skip to content
This repository has been archived by the owner on Sep 1, 2021. It is now read-only.

Re-roll from notification #110

Open
AndreMiras opened this issue Sep 17, 2018 · 1 comment
Open

Re-roll from notification #110

AndreMiras opened this issue Sep 17, 2018 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@AndreMiras
Copy link
Owner

On roll result notification it would be great to have a button to roll again on same parameters.

@AndreMiras AndreMiras added the enhancement New feature or request label Sep 17, 2018
@AndreMiras
Copy link
Owner Author

In Android, this seems possible via the addAction() method. This method must be called on the Notification object created by the Notification-Builder.
Adding custom actons is not currently available in plyer, since the notification facade doesn't provide such an interface (of "complex" widgets with callbacks).

So to bring it (to Android at least) we may need to override/customize our own notification to change the one provided in plyer/platforms/android/notification.py.
Maybe it's possible to monkey patch the NOTIFICATIONBUILDER to hack the addAction() in without overriding the plyer android notification code completely.

For info, here is Android notification buttons implemented in Kivy https://github.com/Bakterija/android-notification-buttons

Since this is not trivial to have it properly implemented cross-platform, we may keep it for later.

@AndreMiras AndreMiras added the help wanted Extra attention is needed label Oct 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant